Re: [PATCH] wdt: intel-mid: add Magic Closure flag

[Guenter Roeck <linux@roeck-us.net>]

On 10/05/2015 04:49 PM, David Cohen wrote:
> Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog
> is opened, it makes sense to disable watchdog only if it was gracefully
> released.
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>

Makes sense.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/intel-mid_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 0a436b5d1e84..db36d12e2b52 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -101,7 +101,7 @@ static irqreturn_t mid_wdt_irq(int irq, void *dev_id)
>
>   static const struct watchdog_info mid_wdt_info = {
>   	.identity = "Intel MID SCU watchdog",
> -	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
> +	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
>   };
>
>   static const struct watchdog_ops mid_wdt_ops = {
>