From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbbJFDLT (ORCPT ); Mon, 5 Oct 2015 23:11:19 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:54979 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbbJFDLR (ORCPT ); Mon, 5 Oct 2015 23:11:17 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68d-f79ae6d00000149a-5f-56133bd35f33 Content-transfer-encoding: 8BIT Message-id: <56133BD3.80507@samsung.com> Date: Tue, 06 Oct 2015 12:11:15 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Roger Quadros , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: k.kozlowski@samsung.com, ramakrishna.pallala@intel.com, gregkh@linuxfoundation.org, ckeepax@opensource.wolfsonmicro.com, rf@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, myungjoo.ham@samsung.com Subject: Re: [PATCH] extcon: Modify the id and name of external connector References: <1443930336-25422-1-git-send-email-cw00.choi@samsung.com> <56123427.2030702@ti.com> <56123C6C.2020108@samsung.com> <56123D1A.7050307@samsung.com> <5612559D.4040300@ti.com> In-reply-to: <5612559D.4040300@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsWyRsSkSPeytXCYwfQTShb/ptxgt3h2VNui efF6NovXLwwtLu+aw2Zxu3EFm8Xyt//ZLBa+uclkMWviHxaLnkdaDlweO2fdZfdYvOclk8f+ uWvYPV5O/M3m0bdlFaPH8RvbmTw+b5ILYI/isklJzcksSy3St0vgypjXeoa54KxlxY9759kb GO/pdTFyckgImEjcbPzLDmGLSVy4t56ti5GLQ0hgBaNEe99zVpiiVwuuMEEkZjFKNH6YC9bB KyAo8WPyPZYuRg4OZgF5iSOXsiFMdYkpU3Ihyh8wShydvYsJolxD4mPDBDYQm0VAVeLGlx2M IDabgJbE/hc32EB6RQUiJLpPVIKERQRSJCaufskCMocZZM7ziXvB7hEW8JSYdOAX1KG7GSXu fJ7NDJLgFFCT2D/nAVhCQuAnu8T674+htglIfJt8COxQCQFZiU0HmCEek5Q4uOIGywRGsVlI 3pmF8M4shHcWMDKvYhRNLUguKE5KLzLUK07MLS7NS9dLzs/dxAiMz9P/nvXuYLx9wPoQowAH oxIPr8RNoTAh1sSy4srcQ4ymQDdMZJYSTc4HJoG8knhDYzMjC1MTU2Mjc0szJXFeRamfwUIC 6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYmZ/X5VlOlpic0Of4b+MMe9lmUd4y9bfVvl0/y/8/ NfjiZfJsja5xzqFT8tOlxBg2yPx7JPLX1FgpUrxTQ+5Yv9e7Rez7M+f5Xeo90m774cWZZLcT 25TmLj/J9eHDrZ2rY9I3Xv10MHt5lfRdO1n374cSfT+Kt+/atoXto1Twqsvl7I8edcvdUmIp zkg01GIuKk4EAKmswNvKAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42I5/e+xoO5la+Ewg59vpS3+TbnBbvHsqLZF 8+L1bBavXxhaXN41h83iduMKNovlb/+zWSx8c5PJYtbEPywWPY+0HLg8ds66y+6xeM9LJo/9 c9ewe7yc+JvNo2/LKkaP4ze2M3l83iQXwB7VwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pm YKhraGlhrqSQl5ibaqvk4hOg65aZA3SdkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3fkCC4 HiMDNJCwhjFjXusZ5oKzlhU/7p1nb2C8p9fFyMkhIWAi8WrBFSYIW0ziwr31bF2MXBxCArMY JRo/zGUHSfAKCEr8mHyPpYuRg4NZQF7iyKVsCFNdYsqUXIjyB4wSR2fvYoIo15D42DCBDcRm EVCVuPFlByOIzSagJbH/xQ02kF5RgQiJ7hOVIGERgRSJiatfsoDMYQaZ83ziXlaQhLCAp8Sk A7+g7tnNKHHn82xmkASngJrE/jkP2CYwAl2JcN4shPNmIZy3gJF5FaNEakFyQXFSeq5RXmq5 XnFibnFpXrpecn7uJkZwCngmvYPx8C73Q4wCHIxKPLwSN4XChFgTy4orcw8xSnAwK4nw/uQS DhPiTUmsrEotyo8vKs1JLT7EaAr030RmKdHkfGB6yiuJNzQ2MTOyNDI3tDAyNlcS571xiCFM SCA9sSQ1OzW1ILUIpo+Jg1OqgXGrFJOXww7pNds+6PdVnps1baPI3DtvAy6E7+laHPa0RPma Tu+GoJDfu+a/ulfyJsf8K8fBU9P2XHouU6nVab02r+mLQPZluZV369j3XU6bwSz6vmlK7oup qS9nXfgiH7ph4sepgnfCryzOOptj8Eq64OSWn3FyQYrz3f8+X/FeVLi0yD8pNE1YiaU4I9FQ i7moOBEAp3s3PxcDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Roger, On 2015년 10월 05일 19:49, Roger Quadros wrote: > Chanwoo, > > On 05/10/15 12:04, Chanwoo Choi wrote: >> Hi Roger, >> >> On 2015년 10월 05일 18:01, Chanwoo Choi wrote: >>> Hi Roger, >>> >>> On 2015년 10월 05일 17:26, Roger Quadros wrote: >>>> Chanwoo, >>>> >>>> On 04/10/15 06:45, Chanwoo Choi wrote: >>>>> This patch modifies the id and name of external connector with the additional >>>>> prefix to clarify both attribute and meaning of external connector as following: >>>>> - EXTCON_CHG_* mean the charger connector. >>>>> - EXTCON_JACK_* mean the jack connector. >>>>> - EXTCON_DISP_* mean the display port connector. >>>>> >>>>> Following table show the new name of external connector with old name: >>>>> ------------------------------------------------- >>>>> Old extcon name | New extcon name | >>>>> ------------------------------------------------- >>>>> EXTCON_TA | EXTCON_CHG_USB_DCP | >>>>> EXTCON_FAST_CHARGER | EXTCON_CHG_USB_FAST | >>>>> EXTCON_SLOW_CHARGER | EXTCON_CHG_USB_SLOW | >>>>> EXTCON_CHARGE_DOWNSTREAM| EXTCON_CHG_USB_CDP | >>>>> ------------------------------------------------- >>>>> EXTCON_MICROPHONE | EXTCON_JACK_MICROPHONE| >>>>> EXTCON_HEADPHONE | EXTCON_JACK_HEADPHONE | >>>>> EXTCON_LINE_IN | EXTCON_JACK_LINE_IN | >>>>> EXTCON_LINE_OUT | EXTCON_JACK_LINE_OUT | >>>>> EXTCON_VIDEO_IN | EXTCON_JACK_VIDEO_IN | >>>>> EXTCON_VIDEO_OUT | EXTCON_JACK_VIDEO_OUT | >>>>> EXTCON_SPDIF_IN | EXTCON_JACK_SPDIF_IN | >>>>> EXTCON_SPDIF_OUT | EXTCON_JACK_SPDIF_OUT | >>>>> ------------------------------------------------- >>>>> EXTCON_HMDI | EXTCON_DISP_HDMI | >>>>> EXTCON_MHL | EXTCON_DISP_MHL | >>>>> EXTCON_DVI | EXTCON_DISP_DVI | >>>>> EXTCON_VGA | EXTCON_DISP_VGA | >>>>> ------------------------------------------------- >>>>> >>>>> And, when altering the name of USB charger connector, EXTCON refers to the >>>>> "USB battery charging specification"[1] to use the standard name of USB >>>>> charging port as following. Following name of USB charging port are already used >>>>> in power_supply subsystem. We chan check it on patch[2]. >>>>> - EXTCON_CHG_USB /* Standard Downstream Port */ >>>>> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ >>>>> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ >>>>> - EXTCON_CHG_USB_ACA /* Accessory Charging Adapter */ >>>>> >>>>> [1] http://www.usb.org/developers/docs/devclass_docs/USB_Battery_Charging_1.2.pdf >>>>> [2] commit 85efc8a18ce ("[PATCH] power_supply: Add types for USB chargers") >>>>> >>>>> Signed-off-by: Chanwoo Choi >>>>> --- >>>>> drivers/extcon/extcon-arizona.c | 18 ++++++------ >>>>> drivers/extcon/extcon-axp288.c | 12 ++++---- >>>>> drivers/extcon/extcon-max14577.c | 18 ++++++------ >>>>> drivers/extcon/extcon-max77693.c | 32 +++++++++++---------- >>>>> drivers/extcon/extcon-max77843.c | 27 ++++++++++-------- >>>>> drivers/extcon/extcon-max8997.c | 21 +++++++------- >>>>> drivers/extcon/extcon-rt8973a.c | 4 +-- >>>>> drivers/extcon/extcon-sm5502.c | 4 +-- >>>>> drivers/extcon/extcon.c | 60 ++++++++++++++++++++------------------- >>>>> include/linux/extcon.h | 61 +++++++++++++++++++++++----------------- >>>>> 10 files changed, 138 insertions(+), 119 deletions(-) >>>>> >>>> >>>> >>>> >>>>> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c >>>>> index 8dd0af1..505a028 100644 >>>>> --- a/drivers/extcon/extcon.c >>>>> +++ b/drivers/extcon/extcon.c >>>>> @@ -39,37 +39,39 @@ >>>>> #define CABLE_NAME_MAX 30 >>>>> >>>>> static const char *extcon_name[] = { >>>>> - [EXTCON_NONE] = "NONE", >>>>> + [EXTCON_NONE] = "EXTCON_NONE", >>>>> >>>>> /* USB external connector */ >>>>> - [EXTCON_USB] = "USB", >>>>> - [EXTCON_USB_HOST] = "USB-HOST", >>>>> - >>>>> - /* Charger external connector */ >>>>> - [EXTCON_TA] = "TA", >>>>> - [EXTCON_FAST_CHARGER] = "FAST-CHARGER", >>>>> - [EXTCON_SLOW_CHARGER] = "SLOW-CHARGER", >>>>> - [EXTCON_CHARGE_DOWNSTREAM] = "CHARGE-DOWNSTREAM", >>>>> - >>>>> - /* Audio/Video external connector */ >>>>> - [EXTCON_LINE_IN] = "LINE-IN", >>>>> - [EXTCON_LINE_OUT] = "LINE-OUT", >>>>> - [EXTCON_MICROPHONE] = "MICROPHONE", >>>>> - [EXTCON_HEADPHONE] = "HEADPHONE", >>>>> - >>>>> - [EXTCON_HDMI] = "HDMI", >>>>> - [EXTCON_MHL] = "MHL", >>>>> - [EXTCON_DVI] = "DVI", >>>>> - [EXTCON_VGA] = "VGA", >>>>> - [EXTCON_SPDIF_IN] = "SPDIF-IN", >>>>> - [EXTCON_SPDIF_OUT] = "SPDIF-OUT", >>>>> - [EXTCON_VIDEO_IN] = "VIDEO-IN", >>>>> - [EXTCON_VIDEO_OUT] = "VIDEO-OUT", >>>>> - >>>>> - /* Etc external connector */ >>>>> - [EXTCON_DOCK] = "DOCK", >>>>> - [EXTCON_JIG] = "JIG", >>>>> - [EXTCON_MECHANICAL] = "MECHANICAL", >>>>> + [EXTCON_USB] = "EXTCON_USB", >>>>> + [EXTCON_USB_HOST] = "EXTCON_USB_HOST", >>>>> + >>>>> + /* Charging external connector */ >>>>> + [EXTCON_CHG_USB] = "EXTCON_CHG_USB", >>>>> + [EXTCON_CHG_USB_FAST] = "EXTCON_CHG_USB_FAST", >>>>> + [EXTCON_CHG_USB_SLOW] = "EXTCON_CHG_USB_SLOW", >>>> >>>> How does FAST & SLOW correlate to USB specifications? >>> >>> There is no specification about FAST & SLOW USB charger. >>> Just, the datasheet of MUIC (Micro-USB Interface Circuit) device >>> can detect the DCP (Dedicated Charging Port) and more two type charger >>> according to current value as following: >>> >>> For example, >>> max77693 MUIC device (is used on Samsung Galaxy S3) >>> - CHG_USB_DCP: current up to 1.5A >>> - CHG_USB_SLOW : current up to 500mA >>> - CHG_USB_FAST : current up to 1A or 2A >>> >>> max77836 MUIC device (is used on Samsung gear 2) >>> - CHG_USB_DCP: current up to 1.5A >>> - CHG_USB_SLOW : current up to 500mA >>> - CHG_USB_FAST : current up to 1A or 2A >>> >>> max77843 MUIC device (is used on Samsung Galaxy Note4) >>> - CHG_USB_DCP: current up to 1.5A >>> - CHG_USB_SLOW : current up to 500mA >>> - CHG_USB_FAST : current up to 1A or 2A >>> >>> If MUIC device detects the some USB charger which >>> has the more maximum current than DCP, this muic device >>> call the FAST charger. Also, there is oppsite case for SLOW charger. >> >> I think that following name is more appropriate than old name. >> - EXTCON_CHG_USB_SLOW -> EXTCON_CHG_USB_DCP_SLOW >> - EXTCON_CHG_USB_FAST -> EXTCON_CHG_USB_DCP_FAST >> > > Yes that looks more appropriate. > >> >>> >>>> >>>>> + [EXTCON_CHG_USB_DCP] = "EXTCON_CHG_USB_DCP", >>>>> + [EXTCON_CHG_USB_CDP] = "EXTCON_CHG_USB_CDP", >>>> >>>> What about USB ACA? >>> >>> ACA is "Accessory Charging Adapter". But, I didn't understand the role >>> of ACA charger type. I'll drop ACA type on next version. > > ACA is typically used by a docking station which can charge the > embedded host (e.g. mobile phone) as well as allow connecting a > USB peripheral to it. > > The link you gave above for Battery charging spec is in fact just the compliance plan. > The spec is actually available here > http://www.usb.org/developers/docs/devclass_docs/BCv1.2_070312.zip Thanks for your help and guide. I'l look at the battery charging spec for adding the ACA. Thanks, Chanwoo Choi