Re: [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

[Julien Grall <julien.grall@citrix.com>]

On 05/10/2015 14:40, Wei Liu wrote:
> On Sun, Oct 04, 2015 at 08:24:02PM +0100, Julien Grall wrote:
>> The keyword typeof is not portable:
>>
>> /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration
>> of function 'typeof' is invalid in C99
>> [-Werror,-Wimplicit-function-declaration]
>>
>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>>
>> ---
>> Cc: Ian Campbell <ian.campbell@citrix.com>
>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> Cc: Jan Beulich <jbeulich@suse.com>
>> Cc: Keir Fraser <keir@xen.org>
>> Cc: Tim Deegan <tim@xen.org>
>>
>>      This patch is a candidate to backport in Xen 4.6, 4.5 and 4.4.
>>
>>      It would be nice to get this small fix before Xen 4.6 is released.
>>      Without it, it's not possible to build ARM software including Xen
>>      headers with -std=c99.
>
> This patch doesn't fundamentally make the header ISO compliance.

I never said it was fully ISO compliant. It's just enough to build the 
kernel using -std=c99 with Xen headers.

Although I believe this is the only non-ISO code we have within this header.

> And it's a bit too late for 4.6 now.

It will be for Xen 4.6.1 then.

Regards,

-- 
Julien Grall