All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xen.org, Ian.Campbell@citrix.com,
	ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com,
	wei.liu2@citrix.com
Subject: Re: [PATCH] libxc: remove most of tools/libxc/xc_dom_compat_linux.c
Date: Tue, 6 Oct 2015 13:52:16 +0100	[thread overview]
Message-ID: <5613C400.4040209@citrix.com> (raw)
In-Reply-To: <1444131327-22000-1-git-send-email-jgross@suse.com>

On 06/10/15 12:35, Juergen Gross wrote:
> In tools/libxc/xc_dom_compat_linux.c only xc_linux_build() is currently
> being used by an in-tree component (qemu-xen). All other functions are
> superfluous wrappers of the domain builder which can be removed.
>
> Suggested-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Sorry, but NACK.  They are *not* superfluous.

XenServer uses them; xc_dom_linux_build() is the only way to apply
XSA-25 size restrictions to PV kernels and initrds.

~Andrew

  reply	other threads:[~2015-10-06 12:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 11:35 [PATCH] libxc: remove most of tools/libxc/xc_dom_compat_linux.c Juergen Gross
2015-10-06 12:52 ` Andrew Cooper [this message]
2015-10-06 12:58   ` Wei Liu
2015-10-06 13:06     ` Andrew Cooper
2015-10-06 13:17       ` Ian Campbell
2015-10-19 10:36         ` Juergen Gross
2015-10-22 15:22           ` Ian Jackson
2015-10-22 15:38             ` Ian Campbell
2015-10-23  7:15               ` Juergen Gross
2015-10-23  9:42                 ` Ian Campbell
2015-10-23  9:53                   ` Juergen Gross
2015-10-23 10:11                     ` Ian Campbell
2015-10-22 15:51           ` Andrew Cooper
2015-10-22 15:21         ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5613C400.4040209@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.