Re: Chipset & Family

[poma <pomidorabelisima-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 06.10.2015 02:21, poma wrote:
> 4.1.8-200.fc22.x86_64 dmesg:
> [   11.809467] nouveau  [  DEVICE][0000:02:00.0] BOOT0  : 0x098200a2
> [   11.809493] nouveau  [  DEVICE][0000:02:00.0] Chipset: G98 (NV98)
> [   11.809508] nouveau  [  DEVICE][0000:02:00.0] Family : NV50
> 
> 
> 4.3.0-0.rc4.git0.1.fc24.x86_64 dmesg:
> [    2.483843] nouveau 0000:02:00.0: NVIDIA G98 (098200a2)
> 
> 
> Where vanished these Chipset & Family super cool lines?
> 

http://cgit.freedesktop.org/~darktama/nouveau/commit/drm/nouveau/nvkm/engine/device/base.c?id=6cc9e47

commit 6cc9e47f7f574cb3df6b14caebf15b35408b106d
Author: Ben Skeggs <bskeggs@redhat.com>
Date:   Thu Aug 20 14:54:13 2015 +1000

    device: switch to dev_printk macros
    
    Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

 drm/nouveau/nvkm/engine/device/base.c  | 11 +++--------
 ...


-		nv_info(device, "BOOT0  : 0x%08x\n", boot0);
-		nv_info(device, "Chipset: %s (NV%02X)\n",
-			device->cname, device->chipset);
-		nv_info(device, "Family : NV%02X\n", device->card_type);
+		nvdev_info(device, "NVIDIA %s (%08x)\n", device->cname, boot0);



These lines were useful as basic device information,
and as reference to wiki "CodeNames"
http://nouveau.freedesktop.org/wiki/CodeNames

"This page contains a list of some NVIDIA chip code names and their corresponding official GeForce number. If you're running a recent version nouveau, you can find your chipset by doing dmesg | grep -i chipset. This will always be correct, whereas the lists below are approximate."

Notice "dmesg | grep -i chipset"

BTW "NVIDIA" is already visible via 'lspci' - lspci | grep VGA

So only gain is unnecessary information reduction and redundancy.

Please bring Chipset & Family back.


_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau