From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/9] xen/arm: io: Support sign-extension for every read access Date: Tue, 6 Oct 2015 14:55:09 +0100 Message-ID: <5613D2BD.4010509@citrix.com> References: <1444049512-15323-1-git-send-email-julien.grall@citrix.com> <1444049512-15323-4-git-send-email-julien.grall@citrix.com> <1444139220.5302.177.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjSjM-0000LY-5y for xen-devel@lists.xenproject.org; Tue, 06 Oct 2015 13:56:36 +0000 In-Reply-To: <1444139220.5302.177.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 06/10/15 14:47, Ian Campbell wrote: > On Mon, 2015-10-05 at 13:51 +0100, Julien Grall wrote: >> [...] >> + /* >> + * Sign extend if required. >> + * Note that we expect the read handler to have zeroed the bit >> + * unused in the register. > > You were (correctly) going to change this to > Note that we expect the read handler to have zeroed the bits outside the > requested access size. Right and I forgot to update the patch :/. > Apart from that (which I can fix on commit): > Acked-by: Ian Campbell Thank you! Regards, -- Julien Grall