From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 6/9] xen/arm: vgic: Introduce a new field to store the rank index and use it Date: Tue, 6 Oct 2015 14:56:20 +0100 Message-ID: <5613D304.5070207@citrix.com> References: <1444049512-15323-1-git-send-email-julien.grall@citrix.com> <1444049512-15323-7-git-send-email-julien.grall@citrix.com> <1444139499.5302.181.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjSky-0000Rp-Lw for xen-devel@lists.xenproject.org; Tue, 06 Oct 2015 13:58:16 +0000 In-Reply-To: <1444139499.5302.181.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 06/10/15 14:51, Ian Campbell wrote: > On Mon, 2015-10-05 at 13:51 +0100, Julien Grall wrote: >> Having in hand the index for the rank is very handy to avoid computing >> it everytime. > > "every time". > >> For now, use it when enabling/disabling the vIRQs rather than a formula >> which is not obvious to understand. >> >> Also drop the comments which where wrong because a shift by DABT_WORD > > "were" instead of "where". > >> will not give the IRQ number but the index of the register. > > You forgot your S-o-b. oops right. Signed-off-by: Julien Grall > Apart from those: > Acked-by: Ian Campbell > Regards, -- Julien Grall