From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbbJFPbO (ORCPT ); Tue, 6 Oct 2015 11:31:14 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34430 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753679AbbJFPbK (ORCPT ); Tue, 6 Oct 2015 11:31:10 -0400 Subject: Re: [PATCH v3 1/3] uio: add ioctl support To: "Michael S. Tsirkin" , Gleb Natapov References: <20151005030352.GA27303@kroah.com> <561227C0.5050607@cloudius-systems.com> <20151005080149.GB1747@kroah.com> <561252B3.4000406@cloudius-systems.com> <20151005225157-mutt-send-email-mst@redhat.com> <20151006005527-mutt-send-email-mst@redhat.com> <56138774.6090106@cloudius-systems.com> <20151006170857-mutt-send-email-mst@redhat.com> <20151006143031.GZ9539@scylladb.com> <20151006181610-mutt-send-email-mst@redhat.com> Cc: Greg KH , Bruce Richardson , linux-kernel@vger.kernel.org, hjk@hansjkoch.de, avi@cloudius-systems.com, corbet@lwn.net, alexander.duyck@gmail.com, gleb@cloudius-systems.com, stephen@networkplumber.org From: Vlad Zolotarov Message-ID: <5613E93B.6010903@cloudius-systems.com> Date: Tue, 6 Oct 2015 18:31:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20151006181610-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/15 18:19, Michael S. Tsirkin wrote: > On Tue, Oct 06, 2015 at 05:30:31PM +0300, Gleb Natapov wrote: >> On Tue, Oct 06, 2015 at 05:19:22PM +0300, Michael S. Tsirkin wrote: >>> On Tue, Oct 06, 2015 at 11:33:56AM +0300, Vlad Zolotarov wrote: >>>> the solution u propose should be a matter of a separate patch and is >>>> obviously orthogonal to this series. >>> Doesn't work this way, sorry. You want a patch enabling MSI merged, >>> you need to secure the MSI configuration. >>> >> MSI can be enabled right now without the patch by writing directly into >> PCI bar. > By poking at config registers in sysfs? We can block this, or we > can log this, pretty easily. We don't ATM but it's not hard to do. > >> The only thing this patch adds is forwarding the interrupt to >> an eventfd. > This one just adds a bunch of ioctls. The next ones do > more than you describe. This one adds zero ioctls and the next one does exactly what Gleb describes. > >> -- >> Gleb.