From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [RFC 27/29] build: convert HAS_GICV3 use to Kconfig Date: Tue, 6 Oct 2015 10:43:58 -0500 Message-ID: <5613EC3E.8060106@cardoe.com> References: <1444082620-3253-1-git-send-email-cardoe@cardoe.com> <1444082620-3253-28-git-send-email-cardoe@cardoe.com> <5612F8C4.8050701@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3730403085018666000==" Return-path: In-Reply-To: <5612F8C4.8050701@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3730403085018666000== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vIAgAw7TevuJrMDv7asKMgIDUpbe8jeL5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vIAgAw7TevuJrMDv7asKMgIDUpbe8jeL5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/5/15 5:25 PM, Julien Grall wrote: > Hi, Thanks for the quick review! I appreciate it. >=20 > On 05/10/2015 23:03, Doug Goldstein wrote: >> Use the Kconfig generated CONFIG_HAS_GICV3 defines in the code base. >=20 > If you are going to rename all HAS_* to CONFIG_HAS_, please drop the HA= S > which is now redundant. So I am treating the CONFIG_HAS_ defines similar to how the Linux kernel has CONFIG_HAVE_. These are not actually user facing options but instead they are enforced by the architecture instead of being a user facing opti= on. For example CONFIG_HAS_KEXEC means the architecture/platform supports KEXEC but CONFIG_KEXEC would be the user configurable option to turn it on/off. This would be consistent with the current behavior in the Xen tree where HAS_KEXEC means the architecture/platform supports KEXEC while 'kexec' as an env var allows the user to build kexec on or off. >=20 >> >> Signed-off-by: Doug Goldstein >> --- >> xen/arch/arm/Kconfig | 4 ++++ >> xen/arch/arm/Makefile | 2 +- >> xen/arch/arm/Rules.mk | 2 -- >> xen/arch/arm/vgic.c | 2 +- >> xen/include/asm-arm/domain.h | 3 ++- >> xen/include/asm-arm/gic.h | 4 ++-- >> xen/include/asm-arm/vgic.h | 2 +- >> 7 files changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index f100f17..01744c7 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -28,6 +28,10 @@ config ARCH_DEFCONFIG >> default "arch/arm/arm32_defconfig" if ARM_32 >> default "arch/arm/arm64_defconfig" if ARM_64 >> >> +# Select HAS_GICV3 if Generic Interrupt Connect (GICv3) is supported >=20 > s/Connect/Controller/ although saying GICv3 is enough. No need to spell= > out the acronym. >=20 > If you really want to spell it it should be Generic Interrupt Controlle= r > v3. Thanks. I will update those comments. >=20 >> +config HAS_GICV3 >> + bool >> + >=20 > I may have miss something with this change GICv3 is not built anymore > for ARM64. >=20 > The user should be able to get a Xen with the exactly the same features= > after this series without any changes from his side. Definitely my goal with this patchset is to make sure everything behaves the same way it did before. >=20 >> source "common/Kconfig" >> >> source "drivers/Kconfig" >=20 > [...] >=20 >> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain= =2Eh >> index b89727e..4dd72ed 100644 >> --- a/xen/include/asm-arm/domain.h >> +++ b/xen/include/asm-arm/domain.h >> @@ -102,7 +102,8 @@ struct arch_domain >> struct pending_irq *pending_irqs; >> /* Base address for guest GIC */ >> paddr_t dbase; /* Distributor base address */ >> -#ifdef HAS_GICV3 >> + paddr_t cbase; /* CPU base address */ >=20 > Can you please make sure that you series don't re-introduce code or > change it. >=20 > This should be pretty easy to check with grep. I.e any changes in *.c > and *.h files but in lines containing ifdef/endif are likely wrong. >=20 > Regards, >=20 Apologies, I made a mistake during a rebase. --=20 Doug Goldstein --vIAgAw7TevuJrMDv7asKMgIDUpbe8jeL5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWE+xBXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUCRoP/10Mq0i8XAqeU0ka6I709C89 stMmzZg7iNj49SvciL34YFQ673PZdU6/judh19jLJUCujN4Z2z0JrZok01blEpyM AzBz1vzuM1drLPGWbC7gs2HXwGo5w7PMZP2KB05lB3J5jqwcg6DoTsZM5RFJYaxF w0KoUH95Li1NhVA8kjnt2lLFMLpXxs3ogQiNSgWz2hx/KjlXq7F7cELPRlgtcVNF VhinBUHk0YrYgtrbPRlCu+uy0zUyW4tvUvfJd6JRFHKPojY8dZrBWvuOdOu4GHrn ZapkkagSlG/tw5cxYpuj3DA6VQ1jmkzbZJaUrjJinbPpJA4vwq3ucB1afjsEq83L EQlYOwyc74L9E69Fri8h26l/bYTPogtagXGnSiNDyvXkfp7GmXaRIrIbrpFqBPDP z6qc2ym3y+dIk/Lzcoonh74UD+Bcbgasl4pUl+u5jSakPdgTmyw3meZ+/xbHu9U4 VZedrUi6EW6w9NAkhjuKlIH+K9OxcSWhFBeIkruWZ2sdC7P/dzpYvTNE7TNQLkfb 0ZG/eDI3JxUrNxUIGWWeqxReLalVUOMCLVxOhGi+XhGmvlLHr4CoJhHbVwYcE6/l 2y6kKtWixBntKKY2brgmlz2sqFHl5bkCvn/dgAKu16q6j4X1MbZ8GzUpYqcduoxB P9nuAEXD5b0e2N0i3X56 =jLxf -----END PGP SIGNATURE----- --vIAgAw7TevuJrMDv7asKMgIDUpbe8jeL5-- --===============3730403085018666000== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3730403085018666000==--