From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 44DFFE00ECB; Tue, 6 Oct 2015 09:08:56 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.170 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 3CB83E00BDE for ; Tue, 6 Oct 2015 09:08:53 -0700 (PDT) Received: by wiclk2 with SMTP id lk2so166562497wic.1 for ; Tue, 06 Oct 2015 09:08:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=vbU/VeUjPOR1TT3Fyjr9iXYlid8BtxsWgVNYyDahuPk=; b=hGQBE/Z9wkXdmlaVNuVNOkTWZZm91hPmwihnjicg1MhUmAb3vLDVPrbtYveR5f8cvo qQGFs7XUczNtrEzQGofGFvOW8uxr6USFOhfGYQUcrkxtI9PVOvoYa7PGefBL9paejjEm 6jpIrgtNmok6l/s4JRCC3zG5EunkGZsnWzF+V2fCVcPZdq7/MRTWq4j42UgpR8gx3Nl7 rYDB3TIHxi+hKehim3270wYlZM0OTxYJLO2QcXVZPZuz8KNHJRivZ5JbI0XmJzP6isN6 ON8HJcdN7PiG94g/dB2pfX0by/7gPQ+19VPhgob6FsOZv6WjZX0YzcAeRqiE3aD3Ulmf QD+g== X-Gm-Message-State: ALoCoQnJvXYlU0GtkjqgdOAygnYZtAyFG9+8SpWyiRYP+rhoFeV7OvKWlaov3YKOA5Tam26w2WUH X-Received: by 10.194.77.4 with SMTP id o4mr43513876wjw.4.1444147732363; Tue, 06 Oct 2015 09:08:52 -0700 (PDT) Received: from [192.168.0.22] ([2.218.205.118]) by smtp.googlemail.com with ESMTPSA id x9sm33380627wjf.44.2015.10.06.09.08.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2015 09:08:51 -0700 (PDT) Message-ID: <5613F212.8040806@intel.com> Date: Tue, 06 Oct 2015 17:08:50 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: <1443692010-14895-1-git-send-email-elliot.smith@intel.com> <1443692010-14895-4-git-send-email-elliot.smith@intel.com> In-Reply-To: <1443692010-14895-4-git-send-email-elliot.smith@intel.com> Subject: Re: [review-request][PATCH 3/3] toaster: Don't store table data in the browser X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 16:08:56 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Just for the record this patch set was submitted upstream (I updated the wrong thread) Michael On 01/10/15 10:33, Elliot Smith wrote: > As table data is no longer loaded from the history stack > (it's refreshed from the server on navigation), remove > the onpopstate event handler and the code which pushes > the page data onto the stack. > > [YOCTO #7660] > > Signed-off-by: Elliot Smith > --- > bitbake/lib/toaster/toastergui/static/js/table.js | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/bitbake/lib/toaster/toastergui/static/js/table.js b/bitbake/lib/toaster/toastergui/static/js/table.js > index 99b99a0..b30b552 100644 > --- a/bitbake/lib/toaster/toastergui/static/js/table.js > +++ b/bitbake/lib/toaster/toastergui/static/js/table.js > @@ -33,14 +33,6 @@ function tableInit(ctx){ > > loadData(tableParams); > > - window.onpopstate = function(event){ > - if (event.state){ > - tableParams = event.state.tableParams; > - /* We skip loadData and just update the table */ > - updateTable(event.state.tableData); > - } > - }; > - > function loadData(tableParams){ > $.ajax({ > type: "GET", > @@ -49,10 +41,6 @@ function tableInit(ctx){ > headers: { 'X-CSRFToken' : $.cookie('csrftoken')}, > success: function(tableData) { > updateTable(tableData); > - window.history.replaceState({ > - tableData: tableData, > - tableParams: tableParams > - }, null, libtoaster.dumpsUrlParams(tableParams)); > } > }); > }