From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: ad193x-spi: Fixup ad193x_spi_id table
Date: Tue, 06 Oct 2015 18:26:56 +0200 [thread overview]
Message-ID: <5613F650.6020904@metafoo.de> (raw)
In-Reply-To: <1444123596.7405.2.camel@ingics.com>
On 10/06/2015 11:26 AM, Axel Lin wrote:
> AD1939 is missed from the table, so add it.
> AD1936 and AD1937 are controlled by I2C interface, so remove them.
>
> Fixes: e5224f58e3ef ("ASoC: ad193x: add support to ad1934")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks for catching that.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> sound/soc/codecs/ad193x-spi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/ad193x-spi.c b/sound/soc/codecs/ad193x-spi.c
> index 364e8211..b55055a 100644
> --- a/sound/soc/codecs/ad193x-spi.c
> +++ b/sound/soc/codecs/ad193x-spi.c
> @@ -39,9 +39,8 @@ static const struct spi_device_id ad193x_spi_id[] = {
> { "ad193x", AD193X },
> { "ad1933", AD1933 },
> { "ad1934", AD1934 },
> - { "ad1936", AD193X },
> - { "ad1937", AD193X },
> { "ad1938", AD193X },
> + { "ad1939", AD193X },
The adau1328 is actually also support by this driver, though I had send a
patch for this a while ago, but I guess I didn't. But we can add that later
in a separate patch.
> { }
> };
> MODULE_DEVICE_TABLE(spi, ad193x_spi_id);
>
next prev parent reply other threads:[~2015-10-06 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 9:26 [PATCH] ASoC: ad193x-spi: Fixup ad193x_spi_id table Axel Lin
2015-10-06 16:26 ` Lars-Peter Clausen [this message]
2015-10-07 9:45 ` Applied "ASoC: ad193x-spi: Fixup ad193x_spi_id table" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5613F650.6020904@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@atmel.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.