All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Marek Vasut <marex@denx.de>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	"Janusz Użycki" <j.uzycki@elpromaelectronics.com>,
	"Jonathan Cameron" <jic23@kernel.org>
Subject: Re: [PATCH] iio: mxs-lradc: Fix temperature offset
Date: Wed, 7 Oct 2015 09:12:56 +0200	[thread overview]
Message-ID: <5614C5F8.5020000@i2se.com> (raw)
In-Reply-To: <20151007004447.GC3485@piout.net>

Am 07.10.2015 um 02:44 schrieb Alexandre Belloni:
> Hi,
>
> On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote :
>>>> /* The calculated value from the ADC is in Kelvin, we
>>>> * want Celsius for hwmon so the offset is
>>>> - * -272.15 * scale
>>>> + * -273.15 * scale
>>>> */
>>>> - *val = -1075;
>>>> - *val2 = 691699;
>>>> + *val = -1079;
>>>> + *val2 = 644268;
>>>>
>>> i think it would be nice to break down the calculation of these magic values in
>>> a second patch.
>> Indeed, I agree. I hope Alexandre can send another patch for that soon :-)
>>
> On my side, I'm not sure this is worth more than a comment. If
> necessary, I can write that the datasheet specifies that the scale is
> 4/1.012 here also.

I'm okay with that.

  reply	other threads:[~2015-10-07  7:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 14:22 [PATCH] iio: mxs-lradc: Fix temperature offset Alexandre Belloni
2015-10-06 18:43 ` Stefan Wahren
2015-10-06 23:19   ` Marek Vasut
2015-10-07  0:44     ` Alexandre Belloni
2015-10-07  7:12       ` Stefan Wahren [this message]
2015-10-08 21:12         ` Marek Vasut
2015-10-06 23:13 ` Marek Vasut
2015-10-11 14:03   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5614C5F8.5020000@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=j.uzycki@elpromaelectronics.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.