From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Barak Subject: Re: [PATCH 2/2] Do not set shared_ports when nreq > MAX_MSIX Date: Wed, 7 Oct 2015 11:08:40 +0300 Message-ID: <5614D308.4010106@mellanox.com> References: <1444166829-17638-1-git-send-email-clsoto@linux.vnet.ibm.com> <1444166829-17638-2-git-send-email-clsoto@linux.vnet.ibm.com> <5614411E.1070105@linux.vnet.ibm.com> <5614C8E5.8040607@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , Linux Netdev List , Or Gerlitz , To: Carol Soto , Or Gerlitz Return-path: Received: from mail-db3on0084.outbound.protection.outlook.com ([157.55.234.84]:16675 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750947AbbJGIIs (ORCPT ); Wed, 7 Oct 2015 04:08:48 -0400 In-Reply-To: <5614C8E5.8040607@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On 10/7/2015 10:25 AM, Matan Barak wrote: > > > On 10/7/2015 12:46 AM, Carol Soto wrote: >> >> >> On 10/6/2015 4:39 PM, Or Gerlitz wrote: >>> On Wed, Oct 7, 2015 at 12:27 AM, wrote= : >>>> From: Carol L Soto >>>> >>>> If we get MAX_MSIX interrupts would like to have each receive ring >>>> with his own msix interrupt line. >>> so 9293267a3e2a was only partially correct? and/or not fully optim= al? >>> please elaborate more on that in your change log. >> just not fully optimal, with commit 9293267a3e2a if I have 64 MSIXs = and >> 2 ports I can get 8 rings for each port but then the rings will shar= e >> the interrupt lines. For 64 MSIXs we can have each ring with his own >> interrupt line. >> >>>> Fixes: 9293267a3e2a ('net/mlx4_core: Capping number of requested >>>> MSIXs to MAX_MSIX') >>>> Signed-off-by: Carol L Soto >>> Carol, you didn't use net/mlx4: prefix as ask for mlx4 driver patch >>> titles, so please repost, but before that I'd like to see an ack fr= om >>> Matan for this patch as well. >> Sorry completely missed it. When Matan acks will resend it. > > The logic seems correct to me. When there are more nreqs than we coul= d > possibly support (or want to support), there=E2=80=99s no reason to s= hare the > EQs between the different ports. > Thanks for your fix. > Please also clean the shared_ports variable - we don't need this anymor= e. > Regards, > Matan > >>> >>> Or. >>> >>>> --- >>>> drivers/net/ethernet/mellanox/mlx4/main.c | 4 +--- >>>> 1 file changed, 1 insertion(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c >>>> b/drivers/net/ethernet/mellanox/mlx4/main.c >>>> index 006757f..f03f513 100644 >>>> --- a/drivers/net/ethernet/mellanox/mlx4/main.c >>>> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c >>>> @@ -2673,10 +2673,8 @@ static void mlx4_enable_msi_x(struct mlx4_d= ev >>>> *dev) >>>> >>>> nreq =3D min_t(int, dev->caps.num_eqs - >>>> dev->caps.reserved_eqs, >>>> nreq); >>>> - if (nreq > MAX_MSIX) { >>>> + if (nreq > MAX_MSIX) >>>> nreq =3D MAX_MSIX; >>>> - shared_ports =3D true; >>>> - } >>>> >>>> entries =3D kcalloc(nreq, sizeof *entries, GFP_KE= RNEL); >>>> if (!entries) >>>> -- >>>> 1.8.3.1 >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe netdev" = in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>