From: Adrian Hunter <adrian.hunter@intel.com>
To: Jiri Olsa <jolsa@redhat.com>, Matt Mullins <mmullins@twopensource.com>
Cc: acme@kernel.org, Vinson Lee <vlee@twopensource.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@intel.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: get version from uname(2), not /proc
Date: Wed, 7 Oct 2015 11:19:17 +0300 [thread overview]
Message-ID: <5614D585.4010707@intel.com> (raw)
In-Reply-To: <20151007081854.GA20302@krava.landal.opennet>
On 07/10/15 11:18, Jiri Olsa wrote:
> On Tue, Oct 06, 2015 at 03:53:14PM -0700, Matt Mullins wrote:
>> Tools in kmod (e.g. modprobe) compose the module path from the release
>> from uname(2). Because we use the UNAME26 personality, we need perf to
>> find modules located at the same path as the system tools.
>
> I guess it's easy to google this up, but could you
> please state in the changelog what's the difference
> between the current version and the UNAME26 one?
>
> Also state (and check) this change wouldn't affect other
> parts of the code that use this version (if there's any).
Isn't the machine root dir for guests? uname() won't work for them.
next prev parent reply other threads:[~2015-10-07 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 22:53 [PATCH] perf tools: get version from uname(2), not /proc Matt Mullins
2015-10-07 8:18 ` Jiri Olsa
2015-10-07 8:19 ` Adrian Hunter [this message]
2015-10-07 17:11 ` Matt Mullins
2015-10-08 6:26 ` Adrian Hunter
2015-10-07 15:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614D585.4010707@intel.com \
--to=adrian.hunter@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmullins@twopensource.com \
--cc=namhyung@kernel.org \
--cc=vlee@twopensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.