From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbbJGI3m (ORCPT ); Wed, 7 Oct 2015 04:29:42 -0400 Received: from mail1.bemta7.messagelabs.com ([216.82.254.98]:38983 "EHLO mail1.bemta7.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbbJGI3j (ORCPT ); Wed, 7 Oct 2015 04:29:39 -0400 X-Greylist: delayed 386 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Oct 2015 04:29:39 EDT X-Env-Sender: Marc_Gonzalez@sigmadesigns.com X-Msg-Ref: server-4.tower-47.messagelabs.com!1444206190!26222606!1 X-Originating-IP: [195.215.56.170] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Subject: Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal To: Daniel Lezcano , Thomas Gleixner CC: LKML , Mans Rullgard , Mason References: <5613E45C.5020208@sigmadesigns.com> <5614549F.2070002@linaro.org> From: Marc Gonzalez Message-ID: <5614D66A.1060402@sigmadesigns.com> Date: Wed, 7 Oct 2015 10:23:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 SeaMonkey/2.35 MIME-Version: 1.0 In-Reply-To: <5614549F.2070002@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.27.0.114] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello everyone, On 07/10/2015 01:09, Daniel Lezcano wrote: > On 10/06/2015 05:10 PM, Marc Gonzalez wrote: >> Date: Tue, 6 Oct 2015 16:49:28 +0200 >> Subject: [PATCH] clocksource: Sigma Designs Tango 27 MHz xtal > > Fix the patch format. OK. > Subject is clocksource/drivers/tango_xtal: Add new timer ... OK. (84583983c319 didn't seem to follow that convention) >> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator. >> Use it for clocksource, sched_clock, and delay_timer. >> >> Signed-off-by: Marc Gonzalez >> --- >> drivers/clocksource/Makefile | 1 + >> drivers/clocksource/tango_xtal.c | 46 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 47 insertions(+) >> create mode 100644 drivers/clocksource/tango_xtal.c >> >> diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile >> index f228354961ca..46e405673d75 100644 >> --- a/drivers/clocksource/Makefile >> +++ b/drivers/clocksource/Makefile >> @@ -24,6 +24,7 @@ obj-$(CONFIG_ARCH_CLPS711X) += clps711x-timer.o >> obj-$(CONFIG_ARCH_ATLAS7) += timer-atlas7.o >> obj-$(CONFIG_ARCH_MOXART) += moxart_timer.o >> obj-$(CONFIG_ARCH_MXS) += mxs_timer.o >> +obj-$(CONFIG_ARCH_TANGOX) += tango_xtal.o > > Please use the following scheme: > > Add in the clocksource's Kconfig an entry: > > config CLKSRC_TANGO_XTAL > bool "bla bla" if COMPILE_TEST > select CLKSRC_OF > > and then in the arch's Kconfig: > > select CLKSRC_TANGO_XTAL OK. >> obj-$(CONFIG_CLKSRC_PXA) += pxa_timer.o >> obj-$(CONFIG_ARCH_PRIMA2) += timer-prima2.o >> obj-$(CONFIG_ARCH_U300) += timer-u300.o >> diff --git a/drivers/clocksource/tango_xtal.c b/drivers/clocksource/tango_xtal.c >> new file mode 100644 >> index 000000000000..0f2fb293ab75 >> --- /dev/null >> +++ b/drivers/clocksource/tango_xtal.c >> @@ -0,0 +1,46 @@ >> +#include >> +#include >> +#include >> +#include >> +#include > > #include is missing. For my education: this header is already indirectly included; The directive should be explicit to prevent breakage in case other (implicit) includes are reorganized? >> +static void __iomem *xtal_in_cnt; >> +static struct delay_timer delay_timer; >> + >> +static unsigned long read_xtal_counter(void) >> +{ >> + return readl_relaxed(xtal_in_cnt); >> +} >> + >> +static u64 read_sched_clock(void) >> +{ >> + return read_xtal_counter(); >> +} > > static u64 *notrace* read_sched_clock(void) What about read_clocksource? and read_xtal_counter? >> +static cycle_t read_clocksource(struct clocksource *cs) >> +{ >> + return read_xtal_counter(); >> +} >> + >> +static struct clocksource tango_xtal = { >> + .name = "tango-xtal", >> + .rating = 350, >> + .read = read_clocksource, >> + .mask = CLOCKSOURCE_MASK(32), >> + .flags = CLOCK_SOURCE_IS_CONTINUOUS, >> +}; >> + >> +static void __init tango_clocksource_init(struct device_node *np) >> +{ >> + struct clk *clk = of_clk_get(np, 0); >> + unsigned int xtal_freq = clk_get_rate(clk); >> + xtal_in_cnt = of_iomap(np, 0); > > check return code. OK. >> + delay_timer.freq = xtal_freq; >> + delay_timer.read_current_timer = read_xtal_counter; >> + register_current_timer_delay(&delay_timer); >> + sched_clock_register(read_sched_clock, 32, xtal_freq); >> + clocksource_register_hz(&tango_xtal, xtal_freq); > > check return code. OK. New patch coming up. Regards.