From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH 08/12] drm: bridge/dw_hdmi: avoid enabling interface in mode_set Date: Wed, 07 Oct 2015 17:35:29 +0800 Message-ID: <5614E761.8020706@rock-chips.com> References: <20150808160251.GM7557@n2100.arm.linux.org.uk> <5614969D.7030201@rock-chips.com> <20151007091830.GE21513@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20151007091830.GE21513@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: Fabio Estevam , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Andy Yan , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org CgpPbiAxMC8wNy8yMDE1IDA1OjE4IFBNLCBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXggd3JvdGU6 Cj4gT24gV2VkLCBPY3QgMDcsIDIwMTUgYXQgMTE6NTA6NTNBTSArMDgwMCwgWWFraXIgWWFuZyB3 cm90ZToKPj4KPj4gT24gMDgvMDkvMjAxNSAxMjowNCBBTSwgUnVzc2VsbCBLaW5nIHdyb3RlOgo+ Pj4gT24gYSBtb2RlIHNldCwgRFJNIG1ha2VzIHRoZSBmb2xsb3dpbmcgc2VxdWVuY2Ugb2YgY2Fs bHM6Cj4+PiAqIGZvcl9lYWNoX2VuY29kZXIKPj4+ICogICBicmlkZ2UJbW9kZV9maXh1cAo+Pj4g KiAgIGVuY29kZXIJbW9kZV9maXh1cAo+Pj4gKiBjcnRjCQltb2RlX2ZpeHVwCj4+PiAqIGZvcl9l YWNoX2VuY29kZXIKPj4+ICogICBicmlkZ2UJZGlzYWJsZQo+Pj4gKiAgIGVuY29kZXIJcHJlcGFy ZQo+Pj4gKiAgIGJyaWRnZQlwb3N0X2Rpc2FibGUKPj4+ICogZGlzYWJsZSB1bnVzZWQgZW5jb2Rl cnMKPj4+ICogY3J0YwkJcHJlcGFyZQo+Pj4gKiBjcnRjCQltb2RlX3NldAo+Pj4gKiBmb3JfZWFj aF9lbmNvZGVyCj4+PiAqICAgZW5jb2Rlcgltb2RlX3NldAo+Pj4gKiAgIGJyaWRnZQltb2RlX3Nl dAo+Pj4gKiBjcnRjCQljb21taXQKPj4+ICogZm9yX2VhY2hfZW5jb2Rlcgo+Pj4gKiAgIGJyaWRn ZQlwcmVfZW5hYmxlCj4+PiAqICAgZW5jb2Rlcgljb21taXQKPj4+ICogICBicmlkZ2UJZW5hYmxl Cj4+Pgo+Pj4gZHdfaGRtaSBlbmFibGVzIHRoZSBIRE1JIG91dHB1dCBpbiBib3RoIHRoZSBicmlk Z2UgbW9kZV9zZXQoKSBhbmQgYWxzbwo+Pj4gdGhlIGJyaWRnZSBlbmFibGUoKSBzdGVwLiAgVGhp cyBpcyBkdXBsaWNhdGVkIHdvcmsgLSB3ZSBjYW4gYXZvaWQgdGhlCj4+PiBzZXR1cCBpbiBtb2Rl X3NldCgpIGFuZCBqdXN0IGRvIGl0IGluIHRoZSBlbmFibGUoKSBzdGFnZS4gIFRoaXMKPj4+IHNp bXBsaWZpZXMgdGhlIGNvZGUgYSBsaXR0bGUuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogUnVzc2Vs bCBLaW5nIDxybWsra2VybmVsQGFybS5saW51eC5vcmcudWs+Cj4+IEkgaGF2ZSBub3RpY2VkIHRo YXQgZHdfaGRtaSBkcml2ZXIgaGF2ZSBwb3dlcm9uL3Bvd2Vyb2ZmIHdoZW4KPj4gZHJpdmVyIGRl dGVjdCBIUEQgZXZlbnQgaW4gaXJxIHRocmVhZCwgdGhhdCdzIGFsc28gZHVwbGljYXRlZCB3b3Jr cywKPj4gd291bGQgeW91IGxpa2UgdG8gY29sbGVjdCB0aGF0IGNoYW5nZXMgaW50byB0aGlzIG9u ZToKPj4KPj4gc3RhdGljIGlycXJldHVybl90IGR3X2hkbWlfaXJxKGludCBpcnEsIHZvaWQgKmRl dl9pZCkKPj4gewo+PiAgICAgICAgICAuLi4uLi4KPj4KPj4gICAgICAgICAgaWYgKGludHJfc3Rh dCAmIEhETUlfSUhfUEhZX1NUQVQwX0hQRCkgewo+PiAgICAgICAgICAgICAgICAgIGlmIChwaHlf aW50X3BvbCAmIEhETUlfUEhZX0hQRCkgewo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2 X2RiZyhoZG1pLT5kZXYsICJFVkVOVD1wbHVnaW5cbiIpOwo+Pgo+PiAgICAgICAgICAgICAgICAg ICAgICAgICAgaGRtaV9tb2RiKGhkbWksIDAsIEhETUlfUEhZX0hQRCwgSERNSV9QSFlfUE9MMCk7 Cj4+Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBkd19oZG1pX3Bvd2Vyb24oaGRtaSk7ICAg IC8vIG5vIG5lZWQgaGVyZQo+PiAgICAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4+ICAgICAgICAg ICAgICAgICAgICAgICAgICBkZXZfZGJnKGhkbWktPmRldiwgIkVWRU5UPXBsdWdvdXRcbiIpOwo+ Pgo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgaGRtaV9tb2RiKGhkbWksIEhETUlfUEhZX0hQ RCwgSERNSV9QSFlfSFBELAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEhE TUlfUEhZX1BPTDApOwo+Pgo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgZHdfaGRtaV9wb3dl cm9mZihoZG1pKTsgICAgLy8gbm8gbmVlZCBoZXJlCj4+ICAgICAgICAgICAgICAgICAgfQo+PiAg ICAgICAgICAgICAgICAgIGRybV9oZWxwZXJfaHBkX2lycV9ldmVudChoZG1pLT5jb25uZWN0b3Iu ZGV2KTsKPj4gICAgICAgICAgfQo+PiAgICAgICAgICAuLi4uLi4KPj4gfQo+IEknbSB2ZXJ5IG11 Y2ggb2YgdGhlIG9waW5pb24gb2YgbWFraW5nIHNtYWxsIGxvZ2ljYWwgY2hhbmdlcy4gIFRoaXMK PiBwYXRjaCBpcyBvbmUgc21hbGwgbG9naWNhbCBjaGFuZ2UgdG8gdGhlIERSTS1zaWRlIGxvZ2lj IHRvIGdldCByaWQKPiBvZiB0aGUgaWRlbnRpZmllZCBkdXBsaWNhdGlvbiB0aGVyZSB3aXRob3V0 IHRvdWNoaW5nIGFueXRoaW5nIGVsc2UuCj4gSWYgcmVtb3ZpbmcgdGhlIGFib3ZlIGNhbGxzIHRv IGR3X2hkbWlfcG93ZXJvbigpL2R3X2hkbWlfcG93ZXJvZmYoKQo+IHdlcmUgZm91bmQgdG8gY2F1 c2UgYSByZWdyZXNzaW9uLCB0aGVuIHRoZSB3aG9sZSBjaGFuZ2Ugd291bGQgZW5kCj4gdXAgYmVp bmcgcmV2ZXJ0ZWQsIHdoaWNoIHdvdWxkIGJlIGFubm95aW5nLgoKSG1tLi4uIFllYWgsIGl0IGRv IG1ha2Ugc29tZSBkcml2ZXIgbG9naWNhbCBjaGFuZ2VzLCBidXQgSQp0aG91Z2h0IHRoYXQncyBn b29kLCBqdXN0IG1ha2UgYSBjbGVhbiBvbiBIUEQgdGhyZWFkLCBhbmQgSQpkbyBnaXZlIGxvdHMg b2YgdGVzdCBvbiBjaHJvbWUgdHJlZSBhYm91dCB0aGlzIGNoYW5nZXMsIGd1ZXNzCmEgc2VwYXJh dGUgcGF0Y2ggd291bGQgYmUgYmV0dGVyLgoKSWYgeW91IGRvbid0IGZlZWwgZ29vZCBlbm91Z2gg YWJvdXQgdGhpcywgb2theSwgSSB3b3VsZCBnaXZlCm1vcmUgdGVzdCBvbiB0aGF0IGNoYW5nZXMs IGFuZCBzZW5kIHVwc3RyZWFtIHRvIHJlcXVlc3QKY29tbWVudCBsYXRlci4KCi0gWWFraXIKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Wed, 07 Oct 2015 17:35:29 +0800 Subject: [PATCH 08/12] drm: bridge/dw_hdmi: avoid enabling interface in mode_set In-Reply-To: <20151007091830.GE21513@n2100.arm.linux.org.uk> References: <20150808160251.GM7557@n2100.arm.linux.org.uk> <5614969D.7030201@rock-chips.com> <20151007091830.GE21513@n2100.arm.linux.org.uk> Message-ID: <5614E761.8020706@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/07/2015 05:18 PM, Russell King - ARM Linux wrote: > On Wed, Oct 07, 2015 at 11:50:53AM +0800, Yakir Yang wrote: >> >> On 08/09/2015 12:04 AM, Russell King wrote: >>> On a mode set, DRM makes the following sequence of calls: >>> * for_each_encoder >>> * bridge mode_fixup >>> * encoder mode_fixup >>> * crtc mode_fixup >>> * for_each_encoder >>> * bridge disable >>> * encoder prepare >>> * bridge post_disable >>> * disable unused encoders >>> * crtc prepare >>> * crtc mode_set >>> * for_each_encoder >>> * encoder mode_set >>> * bridge mode_set >>> * crtc commit >>> * for_each_encoder >>> * bridge pre_enable >>> * encoder commit >>> * bridge enable >>> >>> dw_hdmi enables the HDMI output in both the bridge mode_set() and also >>> the bridge enable() step. This is duplicated work - we can avoid the >>> setup in mode_set() and just do it in the enable() stage. This >>> simplifies the code a little. >>> >>> Signed-off-by: Russell King >> I have noticed that dw_hdmi driver have poweron/poweroff when >> driver detect HPD event in irq thread, that's also duplicated works, >> would you like to collect that changes into this one: >> >> static irqreturn_t dw_hdmi_irq(int irq, void *dev_id) >> { >> ...... >> >> if (intr_stat & HDMI_IH_PHY_STAT0_HPD) { >> if (phy_int_pol & HDMI_PHY_HPD) { >> dev_dbg(hdmi->dev, "EVENT=plugin\n"); >> >> hdmi_modb(hdmi, 0, HDMI_PHY_HPD, HDMI_PHY_POL0); >> >> dw_hdmi_poweron(hdmi); // no need here >> } else { >> dev_dbg(hdmi->dev, "EVENT=plugout\n"); >> >> hdmi_modb(hdmi, HDMI_PHY_HPD, HDMI_PHY_HPD, >> HDMI_PHY_POL0); >> >> dw_hdmi_poweroff(hdmi); // no need here >> } >> drm_helper_hpd_irq_event(hdmi->connector.dev); >> } >> ...... >> } > I'm very much of the opinion of making small logical changes. This > patch is one small logical change to the DRM-side logic to get rid > of the identified duplication there without touching anything else. > If removing the above calls to dw_hdmi_poweron()/dw_hdmi_poweroff() > were found to cause a regression, then the whole change would end > up being reverted, which would be annoying. Hmm... Yeah, it do make some driver logical changes, but I thought that's good, just make a clean on HPD thread, and I do give lots of test on chrome tree about this changes, guess a separate patch would be better. If you don't feel good enough about this, okay, I would give more test on that changes, and send upstream to request comment later. - Yakir From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbbJGJfj (ORCPT ); Wed, 7 Oct 2015 05:35:39 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:48436 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbJGJfi (ORCPT ); Wed, 7 Oct 2015 05:35:38 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: jon.nettleton@gmail.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5614E761.8020706@rock-chips.com> Date: Wed, 07 Oct 2015 17:35:29 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam , David Airlie , Sascha Hauer , Philipp Zabel , Andy Yan , Jon Nettleton Subject: Re: [PATCH 08/12] drm: bridge/dw_hdmi: avoid enabling interface in mode_set References: <20150808160251.GM7557@n2100.arm.linux.org.uk> <5614969D.7030201@rock-chips.com> <20151007091830.GE21513@n2100.arm.linux.org.uk> In-Reply-To: <20151007091830.GE21513@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2015 05:18 PM, Russell King - ARM Linux wrote: > On Wed, Oct 07, 2015 at 11:50:53AM +0800, Yakir Yang wrote: >> >> On 08/09/2015 12:04 AM, Russell King wrote: >>> On a mode set, DRM makes the following sequence of calls: >>> * for_each_encoder >>> * bridge mode_fixup >>> * encoder mode_fixup >>> * crtc mode_fixup >>> * for_each_encoder >>> * bridge disable >>> * encoder prepare >>> * bridge post_disable >>> * disable unused encoders >>> * crtc prepare >>> * crtc mode_set >>> * for_each_encoder >>> * encoder mode_set >>> * bridge mode_set >>> * crtc commit >>> * for_each_encoder >>> * bridge pre_enable >>> * encoder commit >>> * bridge enable >>> >>> dw_hdmi enables the HDMI output in both the bridge mode_set() and also >>> the bridge enable() step. This is duplicated work - we can avoid the >>> setup in mode_set() and just do it in the enable() stage. This >>> simplifies the code a little. >>> >>> Signed-off-by: Russell King >> I have noticed that dw_hdmi driver have poweron/poweroff when >> driver detect HPD event in irq thread, that's also duplicated works, >> would you like to collect that changes into this one: >> >> static irqreturn_t dw_hdmi_irq(int irq, void *dev_id) >> { >> ...... >> >> if (intr_stat & HDMI_IH_PHY_STAT0_HPD) { >> if (phy_int_pol & HDMI_PHY_HPD) { >> dev_dbg(hdmi->dev, "EVENT=plugin\n"); >> >> hdmi_modb(hdmi, 0, HDMI_PHY_HPD, HDMI_PHY_POL0); >> >> dw_hdmi_poweron(hdmi); // no need here >> } else { >> dev_dbg(hdmi->dev, "EVENT=plugout\n"); >> >> hdmi_modb(hdmi, HDMI_PHY_HPD, HDMI_PHY_HPD, >> HDMI_PHY_POL0); >> >> dw_hdmi_poweroff(hdmi); // no need here >> } >> drm_helper_hpd_irq_event(hdmi->connector.dev); >> } >> ...... >> } > I'm very much of the opinion of making small logical changes. This > patch is one small logical change to the DRM-side logic to get rid > of the identified duplication there without touching anything else. > If removing the above calls to dw_hdmi_poweron()/dw_hdmi_poweroff() > were found to cause a regression, then the whole change would end > up being reverted, which would be annoying. Hmm... Yeah, it do make some driver logical changes, but I thought that's good, just make a clean on HPD thread, and I do give lots of test on chrome tree about this changes, guess a separate patch would be better. If you don't feel good enough about this, okay, I would give more test on that changes, and send upstream to request comment later. - Yakir