From mboxrd@z Thu Jan 1 00:00:00 1970 From: sugar Subject: Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Date: Wed, 7 Oct 2015 18:01:57 +0800 Message-ID: <5614ED95.80603@rock-chips.com> References: <1442979683-9441-1-git-send-email-sugar.zhang@rock-chips.com> <1442979683-9441-2-git-send-email-sugar.zhang@rock-chips.com> <20150923162433.GQ30445@sirena.org.uk> <5608F74C.3000104@rock-chips.com> <20150930184655.GX15635@sirena.org.uk> <5614D162.3020500@rock-chips.com> <20151007092714.GZ12635@sirena.org.uk> <20151007093940.GA12635@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.133]) by alsa0.perex.cz (Postfix) with ESMTP id C4DE8265A3E for ; Wed, 7 Oct 2015 12:02:07 +0200 (CEST) In-Reply-To: <20151007093940.GA12635@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, heiko@sntech.de, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.com, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org CgrlnKggMTAvNy8yMDE1IDE3OjM5LCBNYXJrIEJyb3duIOWGmemBkzoKPiBPbiBXZWQsIE9jdCAw NywgMjAxNSBhdCAxMDoyNzoxNEFNICswMTAwLCBNYXJrIEJyb3duIHdyb3RlOgo+PiBPbiBXZWQs IE9jdCAwNywgMjAxNSBhdCAwNDowMTozOFBNICswODAwLCBzdWdhciB3cm90ZToKPgo+Pj4gaWYg KGRhaS0+c3ltbWV0cmljX3JhdGVzKQo+Pj4gCXJlZ21hcF91cGRhdGVfYml0cyhpMnMtPnJlZ21h cCwgSTJTX0NLUiwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJMlNfQ0tSX1RSQ01f TUFTSywKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJMlNfQ0tSX1RSQ00odmFsKSk7 Cj4KPj4gWWVzLCBzb21ldGhpbmcgbGlrZSB0aGF0LiAgWW91J2xsIG5lZWQgdG8gY2hlY2sgYm90 aCBsaW5rcyBpbiB0aGUgREFJCj4+IGFuZCB0aGUgREFJIGxpbmsgaXRzZWxmIHJhdGhlciB0aGFu IGp1c3QgeW91ciBvd24gREFJIGJ1dCB3ZSBzaG91bGQgaGF2ZQo+PiBhIGhlbHBlciBmdW5jdGlv biBmb3IgdGhhdCAtIEknbGwgYWRkIG9uZSwgbG9vayBvdXQgZm9yIGEgcGF0Y2ggc2hvcnRseS4K Pgo+IEFjdHVhbGx5IG5vLCBub3cgSSBsb29rIGF0IHRoZSBjb2RlIHlvdSBwcm9iYWJseSB3YW50 IHRvIGp1c3QgY2xvbmUgdGhlCj4gY2hlY2sgZnJvbSBzb2NfcGNtX2FwcGx5X3N5bW1ldHJ5KCkg c28gaGF2ZSB0aGF0IGJlOgo+Cj4gCXN0cnVjdCBzbmRfc29jX3BjbV9ydW50aW1lICpydGQgPSBz dWJzdHJlYW0tPnByaXZhdGVfZGF0YTsKPgo+IAlpZiAocnRkLT5kYWlfbGluay0+c3ltbWV0cmlj dF9yYXRlcykgewo+IAl9Cj4KPiBpbnN0ZWFkLgo+CgpPSywgdGhpcyB3aWxsIGJlIGRvbmUgaW4g cGF0Y2hzZXQgdjIsIHRoYW5rcy4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9q ZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v YWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: sugar.zhang@rock-chips.com (sugar) Date: Wed, 7 Oct 2015 18:01:57 +0800 Subject: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support In-Reply-To: <20151007093940.GA12635@sirena.org.uk> References: <1442979683-9441-1-git-send-email-sugar.zhang@rock-chips.com> <1442979683-9441-2-git-send-email-sugar.zhang@rock-chips.com> <20150923162433.GQ30445@sirena.org.uk> <5608F74C.3000104@rock-chips.com> <20150930184655.GX15635@sirena.org.uk> <5614D162.3020500@rock-chips.com> <20151007092714.GZ12635@sirena.org.uk> <20151007093940.GA12635@sirena.org.uk> Message-ID: <5614ED95.80603@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 10/7/2015 17:39, Mark Brown ??: > On Wed, Oct 07, 2015 at 10:27:14AM +0100, Mark Brown wrote: >> On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote: > >>> if (dai->symmetric_rates) >>> regmap_update_bits(i2s->regmap, I2S_CKR, >>> I2S_CKR_TRCM_MASK, >>> I2S_CKR_TRCM(val)); > >> Yes, something like that. You'll need to check both links in the DAI >> and the DAI link itself rather than just your own DAI but we should have >> a helper function for that - I'll add one, look out for a patch shortly. > > Actually no, now I look at the code you probably want to just clone the > check from soc_pcm_apply_symmetry() so have that be: > > struct snd_soc_pcm_runtime *rtd = substream->private_data; > > if (rtd->dai_link->symmetrict_rates) { > } > > instead. > OK, this will be done in patchset v2, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbbJGKCQ (ORCPT ); Wed, 7 Oct 2015 06:02:16 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:33435 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbbJGKCO (ORCPT ); Wed, 7 Oct 2015 06:02:14 -0400 X-Greylist: delayed 7218 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Oct 2015 06:02:14 EDT X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: sugar.zhang@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: sugar.zhang@rock-chips.com X-UNIQUE-TAG: <2fa95e47fae9727520a96ed146ce8e32> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support To: Mark Brown References: <1442979683-9441-1-git-send-email-sugar.zhang@rock-chips.com> <1442979683-9441-2-git-send-email-sugar.zhang@rock-chips.com> <20150923162433.GQ30445@sirena.org.uk> <5608F74C.3000104@rock-chips.com> <20150930184655.GX15635@sirena.org.uk> <5614D162.3020500@rock-chips.com> <20151007092714.GZ12635@sirena.org.uk> <20151007093940.GA12635@sirena.org.uk> Cc: alsa-devel@alsa-project.org, heiko@sntech.de, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.com, linux-rockchip@lists.infradead.org, perex@perex.cz, linux-arm-kernel@lists.infradead.org From: sugar Message-ID: <5614ED95.80603@rock-chips.com> Date: Wed, 7 Oct 2015 18:01:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151007093940.GA12635@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 10/7/2015 17:39, Mark Brown 写道: > On Wed, Oct 07, 2015 at 10:27:14AM +0100, Mark Brown wrote: >> On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote: > >>> if (dai->symmetric_rates) >>> regmap_update_bits(i2s->regmap, I2S_CKR, >>> I2S_CKR_TRCM_MASK, >>> I2S_CKR_TRCM(val)); > >> Yes, something like that. You'll need to check both links in the DAI >> and the DAI link itself rather than just your own DAI but we should have >> a helper function for that - I'll add one, look out for a patch shortly. > > Actually no, now I look at the code you probably want to just clone the > check from soc_pcm_apply_symmetry() so have that be: > > struct snd_soc_pcm_runtime *rtd = substream->private_data; > > if (rtd->dai_link->symmetrict_rates) { > } > > instead. > OK, this will be done in patchset v2, thanks.