From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754101AbbJGN3l (ORCPT ); Wed, 7 Oct 2015 09:29:41 -0400 Received: from mail-db3on0066.outbound.protection.outlook.com ([157.55.234.66]:45049 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753385AbbJGN3j (ORCPT ); Wed, 7 Oct 2015 09:29:39 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@ezchip.com; Subject: Re: error: implicit declaration of function 'zero_bytemask' To: Michal Sojka References: <87k2qyyh4x.fsf@steelpick.2x.cz> CC: lkml From: Chris Metcalf Message-ID: <56151E38.5030006@ezchip.com> Date: Wed, 7 Oct 2015 09:29:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <87k2qyyh4x.fsf@steelpick.2x.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BLUPR07CA0043.namprd07.prod.outlook.com (10.255.223.156) To DB5PR02MB0776.eurprd02.prod.outlook.com (25.161.243.147) X-Microsoft-Exchange-Diagnostics: 1;DB5PR02MB0776;2:DtRGNtLZ9nRpASLgb+U0Xc1CAKxuW8pQpBsLwhL5VZWFFv6L3Be6xgwv9+W1857PyffmWt6xNIjuS0FgCZHACtVZ8+E/VnpvR0TdL/RrhiBxhXvna0yg5jGlcJOnyi4QbVfkuHn0e5UUVoOV+pkAOt/pbiauhtnzG5JMHYFFmwg=;3:FC1hCxvxRyVJAeQz/90afIY60tTgqO9aqcw5YRrA+hdli9v9M9dOuw8D8NADVSkQD4vEOP9XaIjqYm6SLk5esaejEDpjJejOqHtBCPnhme9jAxoKNGMMHshpiAI7R6cwqfzoULPndaZxt0/8pA8B2w==;25:ku44Lk8aSWNGJwkOpB90CBVo8KyMlDDuV4kz3LcR+/jJAhjKlSrl6DLen+G3giMYL6yxyAiXhAqv9RhsAySZxPgkQmL2s4qa5+eQLxqwmkgxqRMNavxl34EWSgqrrqD5fJDUqV2s3PbNzm4xHzIjZwQdSWPtmFVw4J7TeFQPjnuShCHnxHPK93SGHrV4kwH5LlqRSkGO0yGbRmJZRg/EK4wq6JG4JDD5AABDIbWR4K7vuZ6QzvgwdAcx/c+HFRz1PEMt1VviZ2PJcvLKPg14fg==;20:CgCyZzwP7sm5rskw/h0fxA6NO41hEIAC/hsUw18iQRiU6o1dkV52Vdk4IWx+uMyHTIKE2Eq3mgsTIKZ7lhhPyaWH6+m0pFAnMkS3E819RJiqZvjk4HpJ7IOyB0r+d41Zc9Ms8qo106D8RLPori8yAa/D5xg1NTkQ2Ww6VvsS2cs= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB0776; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:DB5PR02MB0776;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB0776; X-Microsoft-Exchange-Diagnostics: 1;DB5PR02MB0776;4:5dKCAyYB/7ZB8n7QVEytPUjcoxWWrCXYOpyyOgcp+9GWOKU6iXUGlNTV3vTb6LoUOLO0gwkwgHelG5SE3IoJbBOpALtZlLd8HL5qjp6YLIjxToawwDZ5sYGlKBUvckuqdN3Wk9rvOkO53bgq9H0WSBoQYO6dOP1wniX1mOYIKubtwd1T14jgScuMc9cn8ACBOyy1H3xlTi6be4S9Yaxmfb+qAJGwIxFtslTfx1YsLTk2A3RTjMWvp0qTO5K1kT3YtAkSC/CPYsdbdsd2h3AZI7meD4bNmUY73Y0zEUjxSwaSuGb9vvjT5z5SuZAp5t9ZURwoVbEKGRQSRFMsDZP3kYKecybv6lk/a1UPe33hQPA= X-Forefront-PRVS: 0722981D2A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(24454002)(377454003)(199003)(189002)(479174004)(65816999)(81156007)(50466002)(19580405001)(97736004)(122386002)(50986999)(33656002)(76176999)(40100003)(66066001)(80316001)(92566002)(105586002)(19580395003)(77096005)(36756003)(64126003)(87976001)(46102003)(99136001)(15975445007)(83506001)(5008740100001)(64706001)(101416001)(4001350100001)(65806001)(47776003)(86362001)(5890100001)(54356999)(59896002)(5001960100002)(87266999)(2950100001)(23746002)(189998001)(5004730100002)(110136002)(42186005)(65956001)(106356001)(5007970100001)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR02MB0776;H:[10.7.0.41];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR02MB0776;23:s80eCxPIxd4sKQwn2PWOTUuADSPRqVPfYHMEX?= =?Windows-1252?Q?7G7DpPetC8Lsq4Iwm/guhqRHHW02ZAp7QtwxxCchaDT1xOAYdnMKDz0P?= =?Windows-1252?Q?RajErFM0D7ItVa+rMa0ArDDpz8H7xSg/2iKmw6fUl79/AL5KVYI2gVWd?= =?Windows-1252?Q?jcyB3/iPIZiklWwjWNiyPFZ41jbS+Z1le1EmwdANuRBFn5q/PnXY1mBo?= =?Windows-1252?Q?mHHHwtCVCvdwLT3FdqwlpM1HzRwk5LlJNRoqmd1Wg90OhZJSOhS0qMii?= =?Windows-1252?Q?NN8yPo5TQ/w67nKSBx5vS7YbmPAImizBDJMJObPP3wLY6Nb+rkwY1W1+?= =?Windows-1252?Q?KOIpFN+XaW3lCJHgA7HbXqHUGndTI5Zibiv/A1WaGuohP8eDRcYiZaK7?= =?Windows-1252?Q?dT9aVwckS8L4vB1+VGDa1JtibmzcCxvNZ2VBJZobGIQhmz/Cn/KbpDcK?= =?Windows-1252?Q?NNlg+bR4cckAK9ZrvYbvf3KYA/Pu8txWfEcWGli7o249MoVvPUJAXrhz?= =?Windows-1252?Q?qG5kIrjRV9M6N4LnO2C9Iv4LAyIA3H+VSns9U0HWmvcPCTiOBhrr+3Eb?= =?Windows-1252?Q?yhlgQjPx0BbE7W4Hatv21Q5Rdv3I3kpnFu+PB4AxKGlM7m9DbDab9fMc?= =?Windows-1252?Q?IT5urVuMAhkzEnBnv6W8tfMoRvlu7kfcBJBfXVSbj+/iaa0EiX27KSwQ?= =?Windows-1252?Q?3sbq2kBwYn5YDylIeSno6YViGLPsVcPFcLWGvl5CCOPWTsk4b5T4/67k?= =?Windows-1252?Q?yUVoV6xFbBsO84sJaR9FdK2Uy8Hjb2c89kLI5x+MKbyTVcrf76RvUozM?= =?Windows-1252?Q?a8M3gYiWGdxqAID16rIl24/Vyw3nCwYNn1CH/IvcMxpjNptkNJMNcLbZ?= =?Windows-1252?Q?74yXAaPmhl0DaNvMfZMJ7ah7uHVCVRQ1gfoslPDuqnO0XzSqofOWwfiN?= =?Windows-1252?Q?CBJug9pPpaZq6aMsi5tKwLsjImffq3nRD2bYgjOaNUNgFnBTXyeOhJIj?= =?Windows-1252?Q?dttoBSMjR/AU7mf+mHsGXfrI6LgcVCDoG4B9tYpfVA06Cr1fqMyVUUn6?= =?Windows-1252?Q?LsqMcGNnGhYNB5HqlowLMjepJJz6mYbLfY4nKj5EPsGp/1dwisyjzGk5?= =?Windows-1252?Q?Njjp4q7brJ8rqRcLgXSscMqGhFuzHPpkGhYYYLE0KiOR9fOwgHgYB9xP?= =?Windows-1252?Q?7p1EKTycyDrisGpvQukHZymaNGpItqHed3+L69VE0f2yan36Nod/Fefu?= =?Windows-1252?Q?zhLjrNmCyuZ4iZay5OouUr/YJkK+AFzggY/LA+5LSubJ1fQgwcyWYZ/a?= =?Windows-1252?Q?HvGgUDd1SeqDVUbPdu0NQVzVt0VIX/1BrX5Pxkw8OUJHIq5xeWZ8oMtG?= =?Windows-1252?Q?iuqwFbZeEyLzGQb6LqwSmlFVOgjlX+Z6KKeZzbHsLKZzPoSolaAPWHU3?= =?Windows-1252?Q?Fukag4wFT82w8TU3C5u4t3fehQBnY4mM5igPhP+M+ZI+FsXEA6bYoYrY?= =?Windows-1252?Q?B91jJA=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR02MB0776;5:erbKcwF2cqJnjAeEv+VdoMf0yqjA5jRpQjGfKdm+3xY7s3HBFFMJL6vQb/+WIneN5CPIGFKgVxS3JlMiOY4Td9JuHM+hEk7jmPp9+fH1CCOSvYSq3AYDKLX1Aiq5HHZPMZ2Na7lE+LW44VmuVny+qA==;24:c8J/RHQfnMmMLaNYbWgMTFLJmt+8dhlz7rF7fKE9yt9umMJN17uudUPpHuTKZ5NoRv8FFf0x1ik9FyHGbD5TyikZG21dCntCr6Cm78+B6Ms=;20:hNmHg6j/TO9uVs8RmrZ35+h6Vd3IQF6QHbbpGTMO+WYNZpAY+CR4VQjoZL74bn8h9Z9Upn1t5dh5aYp2IpRfdA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2015 13:29:36.1659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB0776 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2015 08:53 AM, Michal Sojka wrote: > Dear Chris, > > the following commit breaks my Linux build. > > commit 990486c8af044f89bddfbde1d1cf9fde449bedbf > Author: Chris Metcalf > Date: Tue Oct 6 12:37:41 2015 -0400 > > strscpy: zero any trailing garbage bytes in the destination > > It's possible that the destination can be shadowed in userspace > (as, for example, the perf buffers are now). So we should take > care not to leak data that could be inspected by userspace. > > The error message is: > > lib/string.c: In function 'strscpy': > lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors > > I compile the kernel for PowerPC (32 bit) with the attached config. Ah, it appears that big-endian powerpc does not provide zero_bytemask(), only little-endian. I'll fix this in v3 of the patch series - thanks! -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com