From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>,
Pablo Neira Ayuso <pablo@netfilter.org>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>,
David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [PATCH nf-next 1/2] ipvs: Remove possibly unused variable from ip_vs_out
Date: Wed, 7 Oct 2015 16:58:47 +0300 [thread overview]
Message-ID: <56152517.6020807@cogentembedded.com> (raw)
In-Reply-To: <1444195403-4288-2-git-send-email-horms@verge.net.au>
Hello.
On 10/7/2015 8:23 AM, Simon Horman wrote:
> From: David Ahern <dsa@cumulusnetworks.com>
>
> Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if
> CONFIG_IP_VS_IPV6 is not enabled:
>
> ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’:
> ../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’ [-Wunused-variable]
>
> After the net refactoring there is only 1 user; push the reference to the
> 1 user. While the line length slightly exceeds 80 it seems to be the
> best change.
>
> Fixes: 1b75097dd7a26("ipvs: Pass ipvs into ip_vs_out")
Minor nit: missing space before (. Could be probbably fixed while applying...
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> Acked-by: Julian Anastasov <ja@ssi.bg>
> [horms: updated subject]
> Signed-off-by: Simon Horman <horms@verge.net.au>
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-10-07 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 5:23 [GIT PULL nf-next 0/2] Fourth Round of IPVS Updates for v4.4 Simon Horman
2015-10-07 5:23 ` [PATCH nf-next 1/2] ipvs: Remove possibly unused variable from ip_vs_out Simon Horman
2015-10-07 13:58 ` Sergei Shtylyov [this message]
2015-10-07 14:33 ` [Help needed] Kernel level, OSI layers 2-3 Network driver developments, anyone in Northwest US region ? John D Allen, Leveridge Systems INC
2015-10-12 15:43 ` [PATCH nf-next 1/2] ipvs: Remove possibly unused variable from ip_vs_out Pablo Neira Ayuso
2015-10-14 2:10 ` Simon Horman
2015-10-07 5:23 ` [PATCH nf-next 2/2] ipvs: Remove possibly unused variables from ip_vs_conn_net_{init,cleanup} Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56152517.6020807@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dsa@cumulusnetworks.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.