From: David Daney <ddaney@caviumnetworks.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: <netdev@vger.kernel.org>, Florian Fainelli <f.fainelli@gmail.com>,
Sunil Goutham <sgoutham@cavium.com>,
Radha Mohan Chintakuntla <rchintakuntla@cavium.com>,
David Daney <david.daney@cavium.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: mdio-octeon: Drop obsolete Kconfig advice
Date: Wed, 7 Oct 2015 09:20:48 -0700 [thread overview]
Message-ID: <56154660.3070608@caviumnetworks.com> (raw)
In-Reply-To: <20151007102638.335e9762@endymion.delvare>
On 10/07/2015 01:26 AM, Jean Delvare wrote:
> "Y" was the right answer for MDIO_OCTEON when this option was only
> available on CAVIUM_OCTEON_SOC. But now that the option is visible on
> all (64-bit) systems, this piece of advice no longer makes sense. This
> helper module is selected automatically by drivers which need it
> anyway.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Fixes: a6d6786452 ("net: mdio-octeon: Modify driver to work on both ThunderX and Octeon")
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Sunil Goutham <sgoutham@cavium.com>
> Cc: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> Cc: David Daney <david.daney@cavium.com>
> Cc: David S. Miller <davem@davemloft.net>
Jean, good catch:
Acked-by: David Daney <david.daney@cavium.com>
> ---
> drivers/net/phy/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-4.3-rc4.orig/drivers/net/phy/Kconfig 2015-09-20 23:32:34.000000000 +0200
> +++ linux-4.3-rc4/drivers/net/phy/Kconfig 2015-10-07 10:18:46.260452322 +0200
> @@ -168,8 +168,6 @@ config MDIO_OCTEON
> busses. It is required by the Octeon and ThunderX ethernet device
> drivers.
>
> - If in doubt, say Y.
> -
> config MDIO_SUN4I
> tristate "Allwinner sun4i MDIO interface support"
> depends on ARCH_SUNXI
>
>
next prev parent reply other threads:[~2015-10-07 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 8:26 [PATCH] net: mdio-octeon: Drop obsolete Kconfig advice Jean Delvare
2015-10-07 16:20 ` David Daney [this message]
2015-10-08 12:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56154660.3070608@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.de \
--cc=netdev@vger.kernel.org \
--cc=rchintakuntla@cavium.com \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.