From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 3/4] net: Add IPv6 support to VRF device Date: Wed, 7 Oct 2015 12:46:19 -0600 Message-ID: <5615687B.4070405@cumulusnetworks.com> References: <1444236640-2410-1-git-send-email-dsa@cumulusnetworks.com> <1444236640-2410-4-git-send-email-dsa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev To: Cong Wang Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:36839 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbbJGSqR (ORCPT ); Wed, 7 Oct 2015 14:46:17 -0400 Received: by pablk4 with SMTP id lk4so28781874pab.3 for ; Wed, 07 Oct 2015 11:46:17 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 10/7/15 12:42 PM, Cong Wang wrote: > On Wed, Oct 7, 2015 at 9:50 AM, David Ahern wrote: >> Add support for IPv6 to VRF device driver. Implemenation parallels what >> has been done for IPv4. > [...] >> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig >> index b9ebd0d18a52..c878a0bc2137 100644 >> --- a/drivers/net/Kconfig >> +++ b/drivers/net/Kconfig >> @@ -300,6 +300,7 @@ config NET_VRF >> tristate "Virtual Routing and Forwarding (Lite)" >> depends on IP_MULTIPLE_TABLES && IPV6_MULTIPLE_TABLES >> depends on NET_L3_MASTER_DEV >> + depends on IPV6 > > So vrf will stop functioning without IPV6? This doesn't look correct... > The new functionality does. The inter-module/builtin dependencies are a nightmare. I either make VRF device require IPV6 like the IPVLAN driver does or I split the module into 2 -- 1 for IPv4 and 1 for IPv6. David