From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiada Wang Subject: Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume Date: Thu, 8 Oct 2015 10:34:48 +0900 Message-ID: <5615C838.6010903@mentor.com> References: <1444115215-4388-1-git-send-email-jiada_wang@mentor.com> <1444115215-4388-2-git-send-email-jiada_wang@mentor.com> <20151006105907.GM12635@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from relay1.mentorg.com (relay1.mentorg.com [192.94.38.131]) by alsa0.perex.cz (Postfix) with ESMTP id 03EA1261566 for ; Thu, 8 Oct 2015 03:34:52 +0200 (CEST) In-Reply-To: <20151006105907.GM12635@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, tiwai@suse.com, lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org Hi On 10/06/2015 07:59 PM, Mark Brown wrote: > On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote: > >> + /* All registers have been reset to default value without calling >> + * to regmap interface, even if reset fails, some registers >> + * maybe in intermediate status, so we need to mark regmap >> + * cache_dirty flag. >> + */ >> + regcache_mark_dirty(wm8962->regmap); > > This is a standard thing that applies to almost all devices, there > should be no need for such an extensive comment (which would normally > flag up that there's something weird and surprising going on). > Will remove the comment in next update From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbbJHBgO (ORCPT ); Wed, 7 Oct 2015 21:36:14 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:64182 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbbJHBgM (ORCPT ); Wed, 7 Oct 2015 21:36:12 -0400 Message-ID: <5615C838.6010903@mentor.com> Date: Thu, 8 Oct 2015 10:34:48 +0900 From: Jiada Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Mark Brown CC: , , , , , Subject: Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume References: <1444115215-4388-1-git-send-email-jiada_wang@mentor.com> <1444115215-4388-2-git-send-email-jiada_wang@mentor.com> <20151006105907.GM12635@sirena.org.uk> In-Reply-To: <20151006105907.GM12635@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 10/06/2015 07:59 PM, Mark Brown wrote: > On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote: > >> + /* All registers have been reset to default value without calling >> + * to regmap interface, even if reset fails, some registers >> + * maybe in intermediate status, so we need to mark regmap >> + * cache_dirty flag. >> + */ >> + regcache_mark_dirty(wm8962->regmap); > > This is a standard thing that applies to almost all devices, there > should be no need for such an extensive comment (which would normally > flag up that there's something weird and surprising going on). > Will remove the comment in next update