From mboxrd@z Thu Jan 1 00:00:00 1970 From: petr.cvek@tul.cz (Petr Cvek) Date: Thu, 8 Oct 2015 08:05:25 +0200 Subject: [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera In-Reply-To: <87pp0qa27m.fsf@belgarion.home> References: <5609B365.4060307@tul.cz> <1443876607.4186.35.camel@gmail.com> <87pp0qa27m.fsf@belgarion.home> Message-ID: <561607A5.50406@tul.cz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dne 7.10.2015 v 21:49 Robert Jarzmik napsal(a): > Philipp Zabel writes: > >> Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: >>> This patch adds support for an OV9640 camera to the HTC Magician >>> machine. >>> >>> Signed-off-by: Petr Cvek >> >> Still untested, but looks good to me. > I'm still reluctant to have the reset with the timings handled in the board code > as I consider this should be in the camera driver code > (magician_camera_reset()). It supports an actual state of the OV9640 driver handling. But I can exclude it until OV9640 will be transitioned. I don't have enough information about gpiod and soc-camera and not enough time to maintain multiple different (and dependent) patchsets. I forgot to test the timings ... actually I think I forgot results :-D . It was around the same time I have found I2C fast mode is not working. Will test again. Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbbJHGE5 (ORCPT ); Thu, 8 Oct 2015 02:04:57 -0400 Received: from bubo.tul.cz ([147.230.16.1]:40378 "EHLO bubo.tul.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbbJHGE4 (ORCPT ); Thu, 8 Oct 2015 02:04:56 -0400 Subject: Re: [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera To: Robert Jarzmik , Philipp Zabel , g.liakhovetski@gmx.de References: <5609B365.4060307@tul.cz> <1443876607.4186.35.camel@gmail.com> <87pp0qa27m.fsf@belgarion.home> Cc: daniel@zonque.org, haojian.zhuang@gmail.com, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Petr Cvek Message-ID: <561607A5.50406@tul.cz> Date: Thu, 8 Oct 2015 08:05:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <87pp0qa27m.fsf@belgarion.home> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 7.10.2015 v 21:49 Robert Jarzmik napsal(a): > Philipp Zabel writes: > >> Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: >>> This patch adds support for an OV9640 camera to the HTC Magician >>> machine. >>> >>> Signed-off-by: Petr Cvek >> >> Still untested, but looks good to me. > I'm still reluctant to have the reset with the timings handled in the board code > as I consider this should be in the camera driver code > (magician_camera_reset()). It supports an actual state of the OV9640 driver handling. But I can exclude it until OV9640 will be transitioned. I don't have enough information about gpiod and soc-camera and not enough time to maintain multiple different (and dependent) patchsets. I forgot to test the timings ... actually I think I forgot results :-D . It was around the same time I have found I2C fast mode is not working. Will test again. Petr