diff for duplicates of <56161D59.1020207@huawei.com> diff --git a/a/1.txt b/N1/1.txt index a14731c..4e334d0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,7 +25,7 @@ OK, i will add it. > them regular inline functions rather than using macros. It's much safer > and more readable. > -i agree with you ?i will refactor all the unreadable code? +i agree with you ，i will refactor all the unreadable code。 >> +static int hi655x_regulator_pmic_is_enabled(struct regulator_dev *rdev) >> +{ >> + int ret = 0; @@ -44,7 +44,7 @@ i agree with you ?i will refactor all the unreadable code? > I'm having a hard time parsing the above comment. Please also use the > normal kernel comment style (this is a problem throughout the driver). > -OK. i will modify all of these? +OK. i will modify all of these。 >> + regmap_read(rdev->regmap, ctrl_regs->status_reg, &value); >> + ret = (int)REG_VALUE_GETBITS(value, ctrl_data->shift, >> + ctrl_data->mask); @@ -75,7 +75,7 @@ OK. i will modify all of these? > > Use the regualtor core delay functionality please. -OK?i will modify it? +OK，i will modify it。 > >> +static int hi655x_regulator_pmic_list_voltage_linear(struct regulator_dev *rdev, >> + unsigned int selector) @@ -90,7 +90,7 @@ OK?i will modify it? > code decisions about which regulator we're dealing with into each op > function. > -OK?i will modify it? +OK，i will modify it。 >> +static unsigned int hi655x_regulator_pmic_get_mode( >> + struct regulator_dev *rdev) >> +{ @@ -116,7 +116,7 @@ OK?i will modify it? > I'm not going to review any more of the DT code without binding > documentation. -I will document the dt-binding first? +I will document the dt-binding first。 > >> + /* >> + *initdata mem will release auto; @@ -126,4 +126,4 @@ I will document the dt-binding first? > Remove anything related to your vendor kernel support, this is not > relevant to upstream. > -Thanks?Mark?i agree with you and will modify all of you mentioned soon? +Thanks，Mark，i agree with you and will modify all of you mentioned soon。 diff --git a/a/content_digest b/N1/content_digest index ec65068..557cc33 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,36 @@ "ref\01443611111-3196-1-git-send-email-w.f@huawei.com\0" "ref\01443611111-3196-5-git-send-email-w.f@huawei.com\0" "ref\020150930175857.GK15635@sirena.org.uk\0" - "From\0w.f@huawei.com (wangfei)\0" - "Subject\0[PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator\0" + "From\0wangfei <w.f@huawei.com>\0" + "Subject\0Re: [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator\0" "Date\0Thu, 8 Oct 2015 15:38:01 +0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Mark Brown <broonie@kernel.org>\0" + "Cc\0linux-arm-kernel@lists.infradead.org" + linux-kernel@vger.kernel.org + catalin.marinas@arm.com + will.deacon@arm.com + devicetree@vger.kernel.org + linux@arm.linux.org.uk + robh+dt@kernel.org + pawel.moll@arm.com + mark.rutland@arm.com + ijc+devicetree@hellion.org.uk + khilman@linaro.org + sameo@linux.intel.com + lee.jones@linaro.org + lgirdwood@gmail.com + bintian.wang@huawei.com + xuwei5@hisilicon.com + haojian.zhuang@linaro.org + zhangfei.gao@linaro.org + guodong.xu@linaro.org + jorge.ramirez-ortiz@linaro.org + puck.chen@hisilicon.com + xuyiping@hisilicon.com + kong.kongxinwei@hisilicon.com + z.liuxinliang@hisilicon.com + william.wfei@gmail.com + " zhongkaihua@huawei.com\0" "\00:1\0" "b\0" "On 2015/10/1 1:58, Mark Brown wrote:\n" @@ -34,7 +60,7 @@ "> them regular inline functions rather than using macros. It's much safer\n" "> and more readable.\n" "> \n" - "i agree with you ?i will refactor all the unreadable code?\n" + "i agree with you \357\274\214i will refactor all the unreadable code\343\200\202\n" ">> +static int hi655x_regulator_pmic_is_enabled(struct regulator_dev *rdev)\n" ">> +{\n" ">> +\tint ret = 0;\n" @@ -53,7 +79,7 @@ "> I'm having a hard time parsing the above comment. Please also use the\n" "> normal kernel comment style (this is a problem throughout the driver).\n" "> \n" - "OK. i will modify all of these?\n" + "OK. i will modify all of these\343\200\202\n" ">> +\tregmap_read(rdev->regmap, ctrl_regs->status_reg, &value);\n" ">> +\tret = (int)REG_VALUE_GETBITS(value, ctrl_data->shift,\n" ">> +\t\t\t\t\tctrl_data->mask);\n" @@ -84,7 +110,7 @@ "> \n" "> Use the regualtor core delay functionality please.\n" "\n" - "OK?i will modify it?\n" + "OK\357\274\214i will modify it\343\200\202\n" "> \n" ">> +static int hi655x_regulator_pmic_list_voltage_linear(struct regulator_dev *rdev,\n" ">> +\t\t\t\t unsigned int selector)\n" @@ -99,7 +125,7 @@ "> code decisions about which regulator we're dealing with into each op\n" "> function.\n" "> \n" - "OK?i will modify it?\n" + "OK\357\274\214i will modify it\343\200\202\n" ">> +static unsigned int hi655x_regulator_pmic_get_mode(\n" ">> +\t\t\tstruct regulator_dev *rdev)\n" ">> +{\n" @@ -125,7 +151,7 @@ "> I'm not going to review any more of the DT code without binding\n" "> documentation.\n" "\n" - "I will document the dt-binding first?\n" + "I will document the dt-binding first\343\200\202\n" "> \n" ">> +\t/*\n" ">> +\t*initdata mem will release auto;\n" @@ -135,6 +161,6 @@ "> Remove anything related to your vendor kernel support, this is not\n" "> relevant to upstream.\n" "> \n" - Thanks?Mark?i agree with you and will modify all of you mentioned soon? + "Thanks\357\274\214Mark\357\274\214i agree with you and will modify all of you mentioned soon\343\200\202" -cd247673603c5c0e8e465773c6450d9376faa3fe720e3781839ff40f2020928e +6363d2a83dfd2b2eeccca8e69a35fc01a6eefa5d8acaa37ae83d1383f0ed1266
diff --git a/a/1.txt b/N2/1.txt index a14731c..4e334d0 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -25,7 +25,7 @@ OK, i will add it. > them regular inline functions rather than using macros. It's much safer > and more readable. > -i agree with you ?i will refactor all the unreadable code? +i agree with you ，i will refactor all the unreadable code。 >> +static int hi655x_regulator_pmic_is_enabled(struct regulator_dev *rdev) >> +{ >> + int ret = 0; @@ -44,7 +44,7 @@ i agree with you ?i will refactor all the unreadable code? > I'm having a hard time parsing the above comment. Please also use the > normal kernel comment style (this is a problem throughout the driver). > -OK. i will modify all of these? +OK. i will modify all of these。 >> + regmap_read(rdev->regmap, ctrl_regs->status_reg, &value); >> + ret = (int)REG_VALUE_GETBITS(value, ctrl_data->shift, >> + ctrl_data->mask); @@ -75,7 +75,7 @@ OK. i will modify all of these? > > Use the regualtor core delay functionality please. -OK?i will modify it? +OK，i will modify it。 > >> +static int hi655x_regulator_pmic_list_voltage_linear(struct regulator_dev *rdev, >> + unsigned int selector) @@ -90,7 +90,7 @@ OK?i will modify it? > code decisions about which regulator we're dealing with into each op > function. > -OK?i will modify it? +OK，i will modify it。 >> +static unsigned int hi655x_regulator_pmic_get_mode( >> + struct regulator_dev *rdev) >> +{ @@ -116,7 +116,7 @@ OK?i will modify it? > I'm not going to review any more of the DT code without binding > documentation. -I will document the dt-binding first? +I will document the dt-binding first。 > >> + /* >> + *initdata mem will release auto; @@ -126,4 +126,4 @@ I will document the dt-binding first? > Remove anything related to your vendor kernel support, this is not > relevant to upstream. > -Thanks?Mark?i agree with you and will modify all of you mentioned soon? +Thanks，Mark，i agree with you and will modify all of you mentioned soon。 diff --git a/a/content_digest b/N2/content_digest index ec65068..f932e63 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,10 +1,36 @@ "ref\01443611111-3196-1-git-send-email-w.f@huawei.com\0" "ref\01443611111-3196-5-git-send-email-w.f@huawei.com\0" "ref\020150930175857.GK15635@sirena.org.uk\0" - "From\0w.f@huawei.com (wangfei)\0" - "Subject\0[PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator\0" + "From\0wangfei <w.f@huawei.com>\0" + "Subject\0Re: [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator\0" "Date\0Thu, 8 Oct 2015 15:38:01 +0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Mark Brown <broonie@kernel.org>\0" + "Cc\0<linux-arm-kernel@lists.infradead.org>" + <linux-kernel@vger.kernel.org> + <catalin.marinas@arm.com> + <will.deacon@arm.com> + <devicetree@vger.kernel.org> + <linux@arm.linux.org.uk> + <robh+dt@kernel.org> + <pawel.moll@arm.com> + <mark.rutland@arm.com> + <ijc+devicetree@hellion.org.uk> + <khilman@linaro.org> + <sameo@linux.intel.com> + <lee.jones@linaro.org> + <lgirdwood@gmail.com> + <bintian.wang@huawei.com> + <xuwei5@hisilicon.com> + <haojian.zhuang@linaro.org> + <zhangfei.gao@linaro.org> + <guodong.xu@linaro.org> + <jorge.ramirez-ortiz@linaro.org> + <puck.chen@hisilicon.com> + <xuyiping@hisilicon.com> + <kong.kongxinwei@hisilicon.com> + <z.liuxinliang@hisilicon.com> + <william.wfei@gmail.com> + " <zhongkaihua@huawei.com>\0" "\00:1\0" "b\0" "On 2015/10/1 1:58, Mark Brown wrote:\n" @@ -34,7 +60,7 @@ "> them regular inline functions rather than using macros. It's much safer\n" "> and more readable.\n" "> \n" - "i agree with you ?i will refactor all the unreadable code?\n" + "i agree with you \357\274\214i will refactor all the unreadable code\343\200\202\n" ">> +static int hi655x_regulator_pmic_is_enabled(struct regulator_dev *rdev)\n" ">> +{\n" ">> +\tint ret = 0;\n" @@ -53,7 +79,7 @@ "> I'm having a hard time parsing the above comment. Please also use the\n" "> normal kernel comment style (this is a problem throughout the driver).\n" "> \n" - "OK. i will modify all of these?\n" + "OK. i will modify all of these\343\200\202\n" ">> +\tregmap_read(rdev->regmap, ctrl_regs->status_reg, &value);\n" ">> +\tret = (int)REG_VALUE_GETBITS(value, ctrl_data->shift,\n" ">> +\t\t\t\t\tctrl_data->mask);\n" @@ -84,7 +110,7 @@ "> \n" "> Use the regualtor core delay functionality please.\n" "\n" - "OK?i will modify it?\n" + "OK\357\274\214i will modify it\343\200\202\n" "> \n" ">> +static int hi655x_regulator_pmic_list_voltage_linear(struct regulator_dev *rdev,\n" ">> +\t\t\t\t unsigned int selector)\n" @@ -99,7 +125,7 @@ "> code decisions about which regulator we're dealing with into each op\n" "> function.\n" "> \n" - "OK?i will modify it?\n" + "OK\357\274\214i will modify it\343\200\202\n" ">> +static unsigned int hi655x_regulator_pmic_get_mode(\n" ">> +\t\t\tstruct regulator_dev *rdev)\n" ">> +{\n" @@ -125,7 +151,7 @@ "> I'm not going to review any more of the DT code without binding\n" "> documentation.\n" "\n" - "I will document the dt-binding first?\n" + "I will document the dt-binding first\343\200\202\n" "> \n" ">> +\t/*\n" ">> +\t*initdata mem will release auto;\n" @@ -135,6 +161,6 @@ "> Remove anything related to your vendor kernel support, this is not\n" "> relevant to upstream.\n" "> \n" - Thanks?Mark?i agree with you and will modify all of you mentioned soon? + "Thanks\357\274\214Mark\357\274\214i agree with you and will modify all of you mentioned soon\343\200\202" -cd247673603c5c0e8e465773c6450d9376faa3fe720e3781839ff40f2020928e +aa99efbd302861851e5a7a473013c2a10a3be17eb81da3c39187fdec3393fa5e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.