From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933789AbbJHPA2 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 8 Oct 2015 11:00:28 -0400
Received: from mga03.intel.com ([134.134.136.65]:59033 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933160AbbJHPA0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 8 Oct 2015 11:00:26 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,655,1437462000"; 
   d="scan'208";a="787678755"
Subject: Re: [tip:x86/mm] x86/mm: Warn on W^X mappings
To: Borislav Petkov <bp@alien8.de>, luto@amacapital.net, peterz@infradead.org,
        sds@tycho.nsa.gov, keescook@chromium.org,
        torvalds@linux-foundation.org, efault@gmx.de,
        linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
        tglx@linutronix.de, brgerst@gmail.com, dvlasenk@redhat.com
References: <1444064120-11450-1-git-send-email-sds@tycho.nsa.gov>
 <tip-e1a58320a38dfa72be48a0f1a3a92273663ba6db@git.kernel.org>
 <20151008145707.GA17513@nazgul.tnic>
Cc: linux-tip-commits@vger.kernel.org
From: Arjan van de Ven <arjan@linux.intel.com>
Message-ID: <56168508.7030704@linux.intel.com>
Date: Thu, 8 Oct 2015 08:00:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151008145707.GA17513@nazgul.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/8/2015 7:57 AM, Borislav Petkov wrote:
>> +		pr_info("x86/mm: Checked W+X mappings: passed, no W+X pages found.\n");
> Do we really want to issue anything here in the success case? IMO, we
> should be quiet if the check passes and only scream when something's
> wrong...

I would like the success message to be there.
 From an automated testing perspective (for the distro I work on for example),

"the test runs and it fails",
"the test runs and it passes" and
"the test has not run (because of a bug in the code or config file)"

are different outcomes, where the first and third are test failures,
but without the pr_info at info level, the 2nd and 3rd are indistinguishable.