From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965080AbbJHRT5 (ORCPT ); Thu, 8 Oct 2015 13:19:57 -0400 Received: from relay.parallels.com ([195.214.232.42]:35925 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964961AbbJHRT4 (ORCPT ); Thu, 8 Oct 2015 13:19:56 -0400 Subject: Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed To: "K. Y. Srinivasan" , , , , , , , References: <1444269571-25217-1-git-send-email-kys@microsoft.com> <1444269709-25270-1-git-send-email-kys@microsoft.com> <1444269709-25270-7-git-send-email-kys@microsoft.com> CC: Andrey Smetanin , Haiyang Zhang From: "Denis V. Lunev" Message-ID: <5616A5A9.7020005@openvz.org> Date: Thu, 8 Oct 2015 20:19:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444269709-25270-7-git-send-email-kys@microsoft.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: US-EXCH2.sw.swsoft.com (10.255.249.46) To MSK-EXCH1.sw.swsoft.com (10.67.48.55) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2015 05:01 AM, K. Y. Srinivasan wrote: > From: Denis V. Lunev K.Y., there is one subtle thing in this submission. You have changed "From:" field in comparison with the original letter. I have submitted the patch with "From: Andrey Smetanin " In this case Author: in the resulted git mainstream commit will be Andrey. With your submission the resulted Author will be I. This was already happened once with commit cc2dd4027a43bb36c846f195a764edabc0828602 Author: Denis V. Lunev Date: Sat Aug 1 16:08:20 2015 -0700 mshyperv: fix recognition of Hyper-V guest crash MSR's The situation looks a bit unfair. Can we do something with that now/next time? Den > Before vmbus_connect() synic is setup per vcpu - this means > hypervisor receives writes at synic msr's and probably allocate > hypervisor resources per synic setup. > > If vmbus_connect() failed for some reason it's neccessary to cleanup > synic setup by call hv_synic_cleanup() at each vcpu to get a chance > to free allocated resources by hypervisor per synic. > > This patch does appropriate cleanup in case of vmbus_connect() failure. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > Reviewed-by: Vitaly Kuznetsov > CC: "K. Y. Srinivasan" > CC: Haiyang Zhang > CC: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/vmbus_drv.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index f19b6f7..3297731 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -867,7 +867,7 @@ static int vmbus_bus_init(int irq) > on_each_cpu(hv_synic_init, NULL, 1); > ret = vmbus_connect(); > if (ret) > - goto err_alloc; > + goto err_connect; > > if (vmbus_proto_version > VERSION_WIN7) > cpu_hotplug_disable(); > @@ -885,6 +885,8 @@ static int vmbus_bus_init(int irq) > > return 0; > > +err_connect: > + on_each_cpu(hv_synic_cleanup, NULL, 1); > err_alloc: > hv_synic_free(); > hv_remove_vmbus_irq();