Re: [net-next 07/18] i40e: make i40e_init_pf_fcoe to void

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 10/08/2015 01:47 AM, Jeff Kirsher wrote:

> From: Shannon Nelson <shannon.nelson@intel.com>
>
> i40e_init_pf_fcoe() didn't return anything except 0, it prints enough
> error info already, and no driver logic depends on the return value,
> so this can be void.
>
> Change-ID: Ie6afad849857d87a7064c42c3cce14c74c2f29d8
> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[...]

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> index 5ea75dd..2398d9b 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
[...]
> @@ -326,7 +324,7 @@ int i40e_init_pf_fcoe(struct i40e_pf *pf)
>   	wr32(hw, I40E_GLFCOE_RCTL, val);
>
>   	dev_info(&pf->pdev->dev, "FCoE is supported.\n");
> -	return 0;
> +	return;

    Not needed at all.

>   }
>
>   /**
[...]

MBR, Sergei