All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Jimmy Zhang <jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [cbootimage PATCH v3 3/5] Add support to dump rsa related fields for t210
Date: Thu, 8 Oct 2015 14:42:09 -0600	[thread overview]
Message-ID: <5616D521.1040907@wwwdotorg.org> (raw)
In-Reply-To: <1444333109-3671-4-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 10/08/2015 01:38 PM, Jimmy Zhang wrote:
> Add support to dump rsa pubkey, bct's rsa-pss signature and
> bootloader's rsa-pss signature.

> +static void format_rsa_param(char const * message, void * data)
> +{
> +	u_int8_t *rsa = (u_int8_t *)data;
> +	int byte_index;
> +
> +	printf("%s", message);
> +	for (byte_index = 0; byte_index < ARSE_RSA_PARAM_MAX_BYTES;
> +					++byte_index) {
> +		printf("%02x", *rsa++);
> +
> +		if ((byte_index + 1) % 64 == 0)
> +			printf(";\n");
> +	}
> +
> +	if (byte_index % 64 != 0)
> +		printf(";\n");

The calculations related to byte_index changed here, but weren't 
mentioned in the changelog. The new version looks fine though.

  parent reply	other threads:[~2015-10-08 20:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08 19:38 [cbootimage PATCH v3 0/5] Add RSA signing support Jimmy Zhang
     [not found] ` <1444333109-3671-1-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-08 19:38   ` [cbootimage PATCH v3 1/5] Enable -u | --update option support for t210 Jimmy Zhang
     [not found]     ` <1444333109-3671-2-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-08 20:34       ` Stephen Warren
2015-10-08 19:38   ` [cbootimage PATCH v3 2/5] Add support for update pubkey and rsa-pss signatures Jimmy Zhang
2015-10-08 19:38   ` [cbootimage PATCH v3 3/5] Add support to dump rsa related fields for t210 Jimmy Zhang
     [not found]     ` <1444333109-3671-4-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-08 20:42       ` Stephen Warren [this message]
2015-10-08 19:38   ` [cbootimage PATCH v3 4/5] Add new configuration keyword "RehashBl" Jimmy Zhang
     [not found]     ` <1444333109-3671-5-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-08 20:45       ` Stephen Warren
2015-10-08 19:38   ` [cbootimage PATCH v3 5/5] Add sample shell script to sign bootimage for T210 Jimmy Zhang
     [not found]     ` <1444333109-3671-6-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-08 19:42       ` Jimmy Zhang
2015-10-08 19:38   ` [cbootimage PATCH v3 5/5] Add two sample scripts to do rsa signing for T210 bootimage Jimmy Zhang
     [not found]     ` <1444333109-3671-7-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-08 20:57       ` Stephen Warren
     [not found]         ` <5616D8CA.2040209-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-10-09  2:00           ` Jimmy Zhang
     [not found]             ` <797766912b984b9d840369e86e7b2637-wO81nVYWzR7YuxH7O460wFaTQe2KTcn/@public.gmane.org>
2015-10-09  2:09               ` Stephen Warren
     [not found]                 ` <561721CC.9030307-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-10-09 17:11                   ` Jimmy Zhang
     [not found]                     ` <4666228153ed418ab535fe9011c1ff67-wO81nVYWzR7YuxH7O460wFaTQe2KTcn/@public.gmane.org>
2015-10-09 18:28                       ` Stephen Warren
2015-10-09 20:51                   ` Allen Martin
2015-10-08 20:34   ` [cbootimage PATCH v3 0/5] Add RSA signing support Stephen Warren
  -- strict thread matches above, loose matches on Subject: below --
2015-10-08  0:40 [cbootimage PATCH v3 0/5] Enable --update option support for t210 Jimmy Zhang
     [not found] ` <1444264845-16741-1-git-send-email-jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-10-08  0:40   ` [cbootimage PATCH v3 3/5] Add support to dump rsa related fields " Jimmy Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5616D521.1040907@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.