From: Michael Davidsaver <mdavidsaver@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Exit on reset for armv7-m
Date: Thu, 08 Oct 2015 21:24:16 -0400 [thread overview]
Message-ID: <56171740.2000809@gmail.com> (raw)
In-Reply-To: <CAPokK=pUch7OjFoCBjrt9o2moDywbPtg+mn0xj2RbBO8Dq+zaQ@mail.gmail.com>
On 10/08/2015 04:09 PM, Peter Crosthwaite wrote:
> On Thu, Oct 8, 2015 at 8:40 AM, Michael Davidsaver
> <mdavidsaver@gmail.com> wrote:
>> Implement the SYSRESETREQ bit of the AIRCR register
>> for armv7-m (ie. cortex-m3).
>>
>
> This would serve better as the commit message to the patch (which I
> notice is missing a commit blurb).
Does this warrant sending an updated patch? I would have no objection to whomever applies the patch simply changing the commit message.
>> A small patch to see if I have the submission process figured out.
>>
>
> It is usual for the cover and patches to be enumerated together with
> the cover being patch 0, e.g. the subject would read [PATCH 0/1]. the
> --cover-letter switch of git format-patch does this for you.
Alas in this case it did not. Probably because I omitted '--numbered'.
>> Michael Davidsaver (1):
>
> When sending a single, a cover is not required. You could just send
> the patch on it's own. This will all be useful when you come to send
> multi-patch series however.
Noted.
Thanks for the feedback Peter.
Michael
next prev parent reply other threads:[~2015-10-09 1:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 15:40 [Qemu-devel] [PATCH] Exit on reset for armv7-m Michael Davidsaver
2015-10-08 15:40 ` [Qemu-devel] [PATCH] armv7-m: exit on external reset request Michael Davidsaver
2015-10-09 16:59 ` Peter Maydell
2015-10-09 17:25 ` Michael Davidsaver
2015-10-09 18:18 ` Peter Crosthwaite
2015-10-09 18:51 ` Michael Davidsaver
2015-10-10 14:35 ` Michael Davidsaver
2015-10-10 18:54 ` [Qemu-devel] [PATCH v2] " Michael Davidsaver
2015-10-11 15:06 ` Peter Crosthwaite
2015-10-12 3:36 ` [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init() Michael Davidsaver
2015-10-30 21:15 ` Peter Crosthwaite
2015-10-30 21:20 ` Peter Crosthwaite
2015-10-30 21:35 ` Peter Maydell
2015-10-12 3:36 ` [Qemu-devel] [PATCH v3 2/3] armv7-m: Implement SYSRESETREQ Michael Davidsaver
2015-10-30 21:16 ` Peter Crosthwaite
2015-10-12 3:36 ` [Qemu-devel] [PATCH v3 3/3] stellaris: exit on external reset request Michael Davidsaver
2015-10-30 21:13 ` Peter Crosthwaite
2015-10-08 20:09 ` [Qemu-devel] [PATCH] Exit on reset for armv7-m Peter Crosthwaite
2015-10-09 1:24 ` Michael Davidsaver [this message]
2015-10-09 4:21 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56171740.2000809@gmail.com \
--to=mdavidsaver@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.