From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbbJICiE (ORCPT ); Thu, 8 Oct 2015 22:38:04 -0400 Received: from mga11.intel.com ([192.55.52.93]:63236 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756241AbbJICiC (ORCPT ); Thu, 8 Oct 2015 22:38:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,657,1437462000"; d="scan'208";a="660779971" Subject: Re: [PATCH 1/1] x86/io_apic: suppress compiler warning To: Andy Shevchenko , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , x86@kernel.org References: <1444319718-33529-1-git-send-email-andriy.shevchenko@linux.intel.com> From: Jiang Liu Organization: Intel Message-ID: <56172888.90005@linux.intel.com> Date: Fri, 9 Oct 2015 10:38:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444319718-33529-1-git-send-email-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/8 23:55, Andy Shevchenko wrote: > We have to define internally used function as static, otherwise the following > warning will be generated: > > arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes] Hi Andy, Thanks for fixing this. Reviewed-by: Jiang Liu > > Signed-off-by: Andy Shevchenko > --- > arch/x86/kernel/apic/io_apic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > index 5c60bb1..b5a0e3c 100644 > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector) > } > } > > -void eoi_ioapic_pin(int vector, struct mp_chip_data *data) > +static void eoi_ioapic_pin(int vector, struct mp_chip_data *data) > { > unsigned long flags; > struct irq_pin_list *entry; >