From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] tools: remove unused wrappers for python Date: Fri, 9 Oct 2015 12:16:22 +0200 Message-ID: <561793F6.4090107@suse.com> References: <1444128368-31585-1-git-send-email-jgross@suse.com> <20151006111849.GW29124@zion.uk.xensource.com> <5613B1A2.2030800@suse.com> <20151006113902.GY29124@zion.uk.xensource.com> <1444138837.5302.174.camel@citrix.com> <5613DFF9.6000309@suse.com> <5613E7B0.5020405@oracle.com> <1444315101.1410.211.camel@citrix.com> <56168747.6050109@oracle.com> <1444318021.1410.242.camel@citrix.com> <56169AAC.5000502@oracle.com> <561745A0.9080207@suse.com> <1444383784.1410.321.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1444383784.1410.321.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Zhigang Wang , Andrew Cooper Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, Wei Liu , stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 10/09/2015 11:43 AM, Ian Campbell wrote: > On Fri, 2015-10-09 at 06:42 +0200, Juergen Gross wrote: > >> Is it okay to remove all of the unused bindings? > > Please can you remind me what your motivation is here, just cleaning up > detritus or are some of these bindings actively hindering work you are > doing? Or are they known to be broken? With the "superpages" feature removal patch I sent yesterday they are no longer hindering me. OTOH with xend as the only in-tree user being removed some cleaning up seems to be appropriate IMHO. > If it's just tidying up and not getting in your way then I'm not sure this > is worth the effort, but to answer your question above: > > IMHO (and other tools maintainers may disagree) ones which are truly to the > best of our knowledge unused, yes. "To the best of our knowledge" probably > involves some due diligence and fair warning first. I agree. > It would be best to announce the intention on xen-devel in a mail with a > subject ("Intention to deprectate and remove some Python libxc bindings) > which will garner sufficient attention (i.e. not below a patch posting > thread) and Cc anyone who we think might be using the interfaces (Andy, > Zhigang, the chap from invisible-things who spoke up recently in a similar > thread if not this exact one). > > It is probably worth cross posting to xen-users to get input from there. Okay, I'll do that. Juergen