From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/2] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level Date: Fri, 9 Oct 2015 11:17:19 +0100 Message-ID: <5617942F.4040503@linux.intel.com> References: <1444127996-23561-1-git-send-email-chris@chris-wilson.co.uk> <1444127996-23561-2-git-send-email-chris@chris-wilson.co.uk> <561540E5.7050207@linux.intel.com> <20151007161935.GG27939@nuc-i3427.alporthouse.com> <56163837.5070302@linux.intel.com> <20151008094601.GL27939@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id D16FF6E3B8 for ; Fri, 9 Oct 2015 03:17:21 -0700 (PDT) In-Reply-To: <20151008094601.GL27939@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzEwLzE1IDEwOjQ2LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gVGh1LCBPY3QgMDgs IDIwMTUgYXQgMTA6MzI6MzlBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9u IDA3LzEwLzE1IDE3OjE5LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBPbiBXZWQsIE9jdCAwNywg MjAxNSBhdCAwNDo1NzoyNVBNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4+Pgo+Pj4+ IEhpLAo+Pj4+Cj4+Pj4gT24gMDYvMTAvMTUgMTE6MzksIENocmlzIFdpbHNvbiB3cm90ZToKPj4+ Pj4gU2luY2UgdGhlIHJlbW92ZSBvZiB0aGUgcGluLWlvY3RsLCB3ZSBvbmx5IGNhcmUgYWJvdXQg bm90IGNoYW5naW5nIHRoZQo+Pj4+PiBjYWNoZSBsZXZlbCBvbiBidWZmZXJzIHBpbm5lZCB0byB0 aGUgaGFyZHdhcmUgYXMgaW5kaWNhdGVkIGJ5Cj4+Pj4+IG9iai0+cGluX2Rpc3BsYXkuIFNvIHdl IGNhbiBzYWZlbHkgcmVwbGFjZSBpOTE1X2dlbV9vYmplY3RfaXNfcGlubmVkKCkKPj4KPj4gW3Nu aXBdCj4+Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4+PiBpbmRleCBkNGEzYmRmMGM1 YjYuLjJiOGVkN2EyZmFhYiAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+ Pj4+IEBAIC0zNjI5LDMxICszNjI5LDM0IEBAIGludCBpOTE1X2dlbV9vYmplY3Rfc2V0X2NhY2hl X2xldmVsKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4+Pj4+ICAgewo+Pj4+PiAg IAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gb2JqLT5iYXNlLmRldjsKPj4+Pj4gICAJc3RydWN0 IGk5MTVfdm1hICp2bWEsICpuZXh0Owo+Pj4+PiArCWJvb2wgYm91bmQgPSBmYWxzZTsKPj4+Pj4g ICAJaW50IHJldCA9IDA7Cj4+Pj4+Cj4+Pj4+ICAgCWlmIChvYmotPmNhY2hlX2xldmVsID09IGNh Y2hlX2xldmVsKQo+Pj4+PiAgIAkJZ290byBvdXQ7Cj4+Pj4+Cj4+Pj4+IC0JaWYgKGk5MTVfZ2Vt X29ial9pc19waW5uZWQob2JqKSkgewo+Pj4+PiAtCQlEUk1fREVCVUcoImNhbiBub3QgY2hhbmdl IHRoZSBjYWNoZSBsZXZlbCBvZiBwaW5uZWQgb2JqZWN0c1xuIik7Cj4+Pj4+IC0JCXJldHVybiAt RUJVU1k7Cj4+Pj4+IC0JfQo+Pj4+PiAtCj4+Pj4+ICAgCWxpc3RfZm9yX2VhY2hfZW50cnlfc2Fm ZSh2bWEsIG5leHQsICZvYmotPnZtYV9saXN0LCB2bWFfbGluaykgewo+Pj4+PiArCQlpZiAoIWRy bV9tbV9ub2RlX2FsbG9jYXRlZCgmdm1hLT5ub2RlKSkKPj4+Pj4gKwkJCWNvbnRpbnVlOwo+Pj4+ PiArCj4+Pj4+ICsJCWlmICh2bWEtPnBpbl9jb3VudCkgewo+Pj4+PiArCQkJRFJNX0RFQlVHKCJj YW4gbm90IGNoYW5nZSB0aGUgY2FjaGUgbGV2ZWwgb2YgcGlubmVkIG9iamVjdHNcbiIpOwo+Pj4+ PiArCQkJcmV0dXJuIC1FQlVTWTsKPj4+Pj4gKwkJfQo+Pj4+PiArCj4+Pj4KPj4+PiBCdXQgdGhp cyBpcyB0aGUgc2FtZSBhcyBpOTE1X2dlbV9vYmpfaXNfcGlubmVkLCB3aGVyZSBpcyB0aGUKPj4+ PiBvYmotPnBpbl9kaXNwbGF5IGNoYW5nZSBjb21taXQgbWVzc2FnZSB0YWxrcyBhYm91dD8KPj4+ Cj4+PiBSaWdodCBoZXJlLiBUaGUgZGlmZmVyZW5jZSBpcyB0aGF0IHdlIGFyZSBvbmx5IGl0ZXJh dGluZyB0aGUgdm1hIGxpc3QKPj4+IG9uY2UgcmF0aGVyIHRoYW4gM3guCj4+Cj4+IFRoYXRzIHRy dWUsIGJ1dCB0aGUgY29tbWl0IHNheXMgaXQgaXMgZ29pbmcgdG8gdXNlIG9iai0+cGluX2Rpc3Bs YXkKPj4gZm9yIHNvbWV0aGluZyBhbmQgdGhlbiBkb2Vzbid0IHVzZSBpdCBhdCBhbGwuIFJpZGRs ZXMgaW4gcGF0Y2hlcyBhcmUKPj4gbm90IHRoYXQgaG90LiA6KQo+Cj4gSSB3YXMgdHJ5aW5nIHRv IGV4cGxhaW4gd2hhdCB0aGUgYWN0dWFsIHJ1bGVzIHBlcnRhaW5pbmcgdG8gdGhlCj4gcmViaW5k aW5nIHRoZSB2bWEgd2FzLiBXZSBjYW4gcmViaW5kIGFueXRoaW5nIHRoYXQgaXNuJ3QgcGlubmVk IGFuZCB0aGUKPiBvbmx5IHRoaW5nIHBpbm5lZCBoZXJlIGNhbiBiZSBvYmotPnBpbl9kaXNwbGF5 LgoKT2theSBidXQgdGhlIGNvbW1pdCBtZXNzYWdlIHNheXMgdGhlIGlzIGdvaW5nIHRvIHVzZSBv YmotPnBpbl9kaXNwbGF5LgoKPj4+Pj4gICAJCWlmICghaTkxNV9nZW1fdmFsaWRfZ3R0X3NwYWNl KHZtYSwgY2FjaGVfbGV2ZWwpKSB7Cj4+Pj4+ICAgCQkJcmV0ID0gaTkxNV92bWFfdW5iaW5kKHZt YSk7Cj4+Pj4+ICAgCQkJaWYgKHJldCkKPj4+Pj4gICAJCQkJcmV0dXJuIHJldDsKPj4+Pj4gLQkJ fQo+Pj4+PiArCQl9IGVsc2UKPj4+Pj4gKwkJCWJvdW5kID0gdHJ1ZTsKPj4+Pj4gICAJfQo+Pj4+ Pgo+Pj4+PiAtCWlmIChpOTE1X2dlbV9vYmpfYm91bmRfYW55KG9iaikpIHsKPj4+Pj4gKwlpZiAo Ym91bmQpIHsKPj4+Pj4gICAJCXJldCA9IGk5MTVfZ2VtX29iamVjdF93YWl0X3JlbmRlcmluZyhv YmosIGZhbHNlKTsKPj4+Pj4gICAJCWlmIChyZXQpCj4+Pj4+ICAgCQkJcmV0dXJuIHJldDsKPj4+ Pj4KPj4+Pj4gLQkJaTkxNV9nZW1fb2JqZWN0X2ZpbmlzaF9ndHQob2JqKTsKPj4+Pj4gLQo+Pj4+ PiAgIAkJLyogQmVmb3JlIFNhbmR5QnJpZGdlLCB5b3UgY291bGQgbm90IHVzZSB0aWxpbmcgb3Ig ZmVuY2UKPj4+Pj4gICAJCSAqIHJlZ2lzdGVycyB3aXRoIHNub29wZWQgbWVtb3J5LCBzbyByZWxp bnF1aXNoIGFueSBmZW5jZXMKPj4+Pj4gICAJCSAqIGN1cnJlbnRseSBwb2ludGluZyB0byBvdXIg cmVnaW9uIGluIHRoZSBhcGVydHVyZS4KPj4+Pj4gQEAgLTM2NjQsMTMgKzM2NjcsMTggQEAgaW50 IGk5MTVfZ2VtX29iamVjdF9zZXRfY2FjaGVfbGV2ZWwoc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl Y3QgKm9iaiwKPj4+Pj4gICAJCQkJcmV0dXJuIHJldDsKPj4+Pj4gICAJCX0KPj4+Pj4KPj4+Pj4g LQkJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsICZvYmotPnZtYV9saXN0LCB2bWFfbGluaykKPj4+ Pj4gLQkJCWlmIChkcm1fbW1fbm9kZV9hbGxvY2F0ZWQoJnZtYS0+bm9kZSkpIHsKPj4+Pj4gLQkJ CQlyZXQgPSBpOTE1X3ZtYV9iaW5kKHZtYSwgY2FjaGVfbGV2ZWwsCj4+Pj4+IC0JCQkJCQkgICAg UElOX1VQREFURSk7Cj4+Pj4+IC0JCQkJaWYgKHJldCkKPj4+Pj4gLQkJCQkJcmV0dXJuIHJldDsK Pj4+Pj4gLQkJCX0KPj4+Pj4gKwkJLyogQWNjZXNzIHRvIHNub29wYWJsZSBwYWdlcyB0aHJvdWdo IHRoZSBHVFQgaXMgaW5jb2hlcmVudC4gKi8KPj4+Pj4gKwkJaWYgKGNhY2hlX2xldmVsICE9IEk5 MTVfQ0FDSEVfTk9ORSAmJiAhSEFTX0xMQyhkZXYpKQo+Pj4+PiArCQkJaTkxNV9nZW1fcmVsZWFz ZV9tbWFwKG9iaik7Cj4+Pj4KPj4+PiBEb24ndCBmdWxseSB1bmRlcnN0YW5kIHRoaXMgb25lIC0g YnV0IG15IHF1ZXN0aW9uIGlzIHRoaXMuCj4+Pj4gUHJldmlvdXNseSB1c2Vyc3BhY2Ugd291bGQg bG9zZSBtYXBwaW5ncyBvbiBjYWNoZSBsZXZlbCBjaGFuZ2VzIGFueQo+Pj4+IHRpbWUsIGFmdGVy IHRoaXMgb25seSBvbiAhTExDIHdoZW4gdHVybmluZyBvbiBjYWNoaW5nIG1vZGUuIFNvIHRoaXMK Pj4+PiBtZWFucyB1c2Vyc3BhY2UgbmVlZHMgdG8ga25vdyBhYm91dCB0aGlzIGNoYW5nZSBhbmQg bW9kaWZ5IGl0J3MKPj4+PiBiZWhhdmlvcj8gT3Igd2hhdCBleGFjdGx5IHdvdWxkIGhhcHBlbiBp biBwcmFjdGljZT8KPj4+Cj4+PiBOby4gVXNlcnNwYWNlIGhhcyBubyBrbm93bGVkZ2Ugb2YgdGhl IGtlcm5lbCBoYW5kbGluZyB0aGUgUFRFcywgaXRzCj4+PiBtYXBwaW5nIGlzIHBlcnNpc3RlbnQg KGkuZS4gdGhlIG9iai0+bW1hcF9vZmZzZXQgaW5zaWRlIHRoZSBkZXYtPm1hcHBwaW5nKS4KPj4+ IE90b2gsIHdlIGFyZSBpbXByb3ZpbmcgdGhlIHNpdHVhdGlvbiBzbyBldmVuIGlmIHVzZXJzcGFj ZSB0cmllcyB0byBhdm9pZAo+Pj4gc2V0LWNhY2hlLWxldmVsIG5vdGhpbmcgaXMgbG9zdC4KPj4K Pj4gSG0gc28gaWYgYSBWTUEgaXMgcmUtYm91bmQgaW4gdGhpcyBwcm9jZXNzIGFuZCBpdCBjb3Vs ZCBoYXZlIGdvdHRlbgo+PiBhIG5ldyBHR1RUIGFkZHJlc3MsIHdoeSBpdCBpcyBub3QgbmVjZXNz YXJ5IHRvIGFsd2F5cyByZWxlYXNlIG1tYXBzCj4+IGFuZCBzbyB0byB1cGRhdGUgQ1BVIFBURXM/ Cj4KPiBUaGUgVk1BIGFyZSBub3QgbW92ZWQgYnkgdGhpcyBmdW5jdGlvbiwgb25seSB0aGUgUFRF cyBhcmUgcmV3cml0dGVuLiBUaGUKPiBHVFQgaWdub3JlcyB0aGUgYml0cyB3ZSBhcmUgY2hhbmdp bmcgb24gbGxjIGFyY2hpdGVjdHVyZXMuIE9uICFsbGMgdXNpbmcKPiB0aGUgR1RUIHRvIGFjY2Vz cyBzbm9vcGFibGUgUFRFIGlzIHZlcmJvdGVuIGFuZCBkb2VzIGNhdXNlIG1hY2hpbmUgaGFuZ3Mu CgpIb3cgY29tZSB0aGV5IGFyZSBub3QgbW92ZWQgd2hlbiB0aGV5IGNhbiBiZSB1bmJvdW5kIGFu ZCB0aGVuIGJvdW5kIGFnYWluPwoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=