From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkXJi-0002Wl-Sd for qemu-devel@nongnu.org; Fri, 09 Oct 2015 09:02:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkXJd-0004H3-80 for qemu-devel@nongnu.org; Fri, 09 Oct 2015 09:02:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkXJd-0004Gy-3w for qemu-devel@nongnu.org; Fri, 09 Oct 2015 09:02:29 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 6BE433824E7 for ; Fri, 9 Oct 2015 13:02:28 +0000 (UTC) From: Eric Blake Message-ID: <5617BAD9.8040205@redhat.com> Date: Fri, 9 Oct 2015 07:02:17 -0600 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O6IVmqF3f0PkfssRI8PKPWgOEpaL8Napn" Subject: [Qemu-devel] simple qmp core dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --O6IVmqF3f0PkfssRI8PKPWgOEpaL8Napn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Just noticed this core dump (I was actually trying to exceed the 1024 hard-baked limit in qmp-input-visitor.c which tries to set an Error object, but it looks like that limit was unreachable due to this earlier assertion): $ printf '{"execute":"qmp_capabilities","id":%1025s' " " | tr ' ' { | ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 4, "major": 2}, "package": ""}, "capabilities": []}} main-loop: WARNING: I/O thread spun for 1000 iterations ** ERROR:qobject/json-parser.c:294:parser_context_peek_token: assertion failed: (ctxt->tokens.pos < ctxt->tokens.count) Aborted (core dumped) I don't know the best way to deal with a client that abuses QMP protocol, but it would at least be nice to not abort. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --O6IVmqF3f0PkfssRI8PKPWgOEpaL8Napn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWF7rZAAoJEKeha0olJ0NqzDkH+wXMwFlITH1ahStMEyoHL94J LSyeauHCckr/RnQrO/84tpjnbzQl2Fs0yZuLdH2tF1hU8u64q1TmCp9k3k7w3Qfi eWKHwPdRB6Lx/KZD4QrS0MZM3z8CJmDhIW6+aUxkRsIYaFfjcSwdPrRx5jcqe6uB y1iBYtFNVubBEk9fZZK76Cu0XOK1a+1gIVvqZPUuVNuRYx9ijloHXgG5GzgZbrO1 PML0l7oMmO8hSVaJD8jM4Z1RXegRsG8ELzrhdHPeBp0FHKPq8PpF+08nXSydBRyE g+CzoArTbbN37/hcPomV0d26LmtHVUHu1+qP0sKvvcVMPM1+Hyh7WbmOTZaqMj8= =c02a -----END PGP SIGNATURE----- --O6IVmqF3f0PkfssRI8PKPWgOEpaL8Napn--