From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756374AbbJINZB (ORCPT ); Fri, 9 Oct 2015 09:25:01 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34812 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbbJINY7 (ORCPT ); Fri, 9 Oct 2015 09:24:59 -0400 Subject: Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs To: Marc Gonzalez , Thomas Gleixner References: <5613E45C.5020208@sigmadesigns.com> <5614549F.2070002@linaro.org> <5614D66A.1060402@sigmadesigns.com> <56150369.2050609@sigmadesigns.com> <561510BF.7050207@linaro.org> <56151B5B.90404@sigmadesigns.com> <56154268.5060700@linaro.org> <56157CB9.7010105@free.fr> <5617AF82.4000606@sigmadesigns.com> Cc: Mason , LKML From: Daniel Lezcano Message-ID: <5617C028.3040709@linaro.org> Date: Fri, 9 Oct 2015 15:24:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5617AF82.4000606@sigmadesigns.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2015 02:13 PM, Marc Gonzalez wrote: > Sigma Designs Tango platforms provide a 27 MHz crystal oscillator. > Use it for clocksource, sched_clock, and delay_timer. > > Signed-off-by: Marc Gonzalez > --- > I have a nagging feeling that the QUIT_IF macro will get this patch NAKed ;-) > My rationale: error-handling tends to take the focus away from the normal > path, and put it on the error path. Hiding the details away in a macro > helps to keep the error-handling noise to a minimum. It is a right feeling :) The Linux kernel code follows the same path all across the different sub-systems. So it is not a problem to write: if (err) ..., people is used to read such code and by introducing this macro, that makes the code less readable for them. Moreover, the way you wrote the macro is strongly discouraged in the CodingStyle document because there is a 'return' inside. -- DAniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog