From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756411AbbJIOnA (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2015 10:43:00 -0400
Received: from mail-wi0-f169.google.com ([209.85.212.169]:37452 "EHLO
	mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756051AbbJIOm6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2015 10:42:58 -0400
Subject: Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for
 Tango SoCs
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
        Thomas Gleixner <tglx@linutronix.de>
References: <5613E45C.5020208@sigmadesigns.com> <5614549F.2070002@linaro.org>
 <5614D66A.1060402@sigmadesigns.com> <56150369.2050609@sigmadesigns.com>
 <561510BF.7050207@linaro.org> <56151B5B.90404@sigmadesigns.com>
 <56154268.5060700@linaro.org> <56157CB9.7010105@free.fr>
 <5617AF82.4000606@sigmadesigns.com> <5617C028.3040709@linaro.org>
 <5617D139.1000103@sigmadesigns.com>
Cc: Mason <slash.tmp@free.fr>, LKML <linux-kernel@vger.kernel.org>
From: Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <5617D26F.5070206@linaro.org>
Date: Fri, 9 Oct 2015 16:42:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <5617D139.1000103@sigmadesigns.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/09/2015 04:37 PM, Marc Gonzalez wrote:
> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
> Use it for clocksource, sched_clock, and delay_timer.
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---

[ ... ]

> +
> +#define QUIT_IF(cond, fmt, ...) do if (cond) {		\
> +	static const char format[] __initconst = fmt;	\
> +	pr_err(format, ## __VA_ARGS__);			\
> +	return;						\
> +} while (0)

hmm ... forget something ?

> +
> +	ret = clocksource_register_hz(&tango_xtal, xtal_freq);
> +	if (ret != 0) {
> +		pr_err("%s: registration failed\n", np->full_name);
> +		return;
> +	}

missing line.

> +	sched_clock_register(read_sched_clock, 32, xtal_freq);
> +	register_current_timer_delay(&delay_timer);
> +}
> +
> +CLOCKSOURCE_OF_DECLARE(tango, "sigma,tick-counter", tango_clocksource_init);
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog