From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933324AbbJIQPH (ORCPT ); Fri, 9 Oct 2015 12:15:07 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33553 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933182AbbJIQPF (ORCPT ); Fri, 9 Oct 2015 12:15:05 -0400 Subject: Re: [RFD] pstore: pmsg: ramoops: add multiple pmsg instances To: Hiraku Toyooka , tony.luck@intel.com, keescook@chromium.org, anton@enomsg.org, ccross@android.com, seiji.aguchi.tr@hitachi.com, LKML References: <56171DF4.2030209@hitachi.com> From: Mark Salyzyn Message-ID: <5617E806.7020407@android.com> Date: Fri, 9 Oct 2015 09:15:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56171DF4.2030209@hitachi.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2015 06:52 PM, Hiraku Toyooka wrote: > Hello, > > I'm trying to make the feature of multiple pmsg instances for ramoops. I like it, in fact I encourage it. This is somewhat/exactly what I did when I first created pmsg, but decided to simplify to one instance for the first release because I was unsure how many bona fide user space consumers there would be, so kept the patch small. I kept the instance number 0 around to allow for expanding this optional feature without introducing incompatibility. But I sold the idea that multiple writers on single instance can occur if a common protocol was used. For my own usage (Android) one instance was more than enough. Multiple instances does allow one to control individual content aging or priority, I agree with your assessment, but make sure that you have a bona fide user for it (even if it is just for yourself)? NB: ToDo: device tree support for pstore configuration Thanks Sincerely -- Mark Salyzyn