From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50300)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZkfvA-0003iy-EU
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 18:13:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zkfv6-0004Ff-R9
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 18:13:48 -0400
Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]:34516)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zkfv6-0004Ex-LL
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 18:13:44 -0400
Received: by padhy16 with SMTP id hy16so97562101pad.1
	for <qemu-devel@nongnu.org>; Fri, 09 Oct 2015 15:13:43 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <COL130-W402A36D36226EFC705AEB8B9490@phx.gbl>
	<5614E3A4.7010302@twiddle.net>
	<BLU436-SMTP4339E4409FC73BB01BBBDCB9360@phx.gbl>
	<5616F327.5020402@hotmail.com>
	<COL130-W508D019C5051265EB08341B9350@phx.gbl>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56183B5A.5060808@twiddle.net>
Date: Sat, 10 Oct 2015 09:10:34 +1100
MIME-Version: 1.0
In-Reply-To: <COL130-W508D019C5051265EB08341B9350@phx.gbl>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop
 instructions return before allocating dest temporary register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <xili_gchen_5257@hotmail.com>, Peter Maydell <peter.maydell@linaro.org>, Chris Metcalf <cmetcalf@ezchip.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 10/09/2015 09:48 AM, Chen Gang wrote:
> On 10/7/15 18:17, Chen Gang wrote:
>> On 10/7/15 17:19, Richard Henderson wrote:
>>> On 10/04/2015 10:15 PM, Chen Gang wrote:
>>>>>  From 40ec3f1c75b4c97e3e0495c9e465be898f48a652 Mon Sep 17 00:00:00 2001
>>>> From: Chen Gang<gang.chen.5i5j@gmail.com>
>>>> Date: Sun, 4 Oct 2015 17:34:17 +0800
>>>> Subject: [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register
>>>>
>>>> Or it will cause issue by the dest temporary registers.
>>>>
>>>> Signed-off-by: Chen Gang<gang.chen.5i5j@gmail.com>
>>>> ---
>>>> target-tilegx/translate.c | 85 +++++++++++++++++++++++++----------------------
>>>> 1 file changed, 46 insertions(+), 39 deletions(-)
>>>
>>> Isn't my patch 14/14 from the last patch set sufficient?
>>>
>
> At present, all patches (include 14/14) are integrated into master tree,
> so I guess, we have to integrate this patch into master tree next, it
> fix the dest temporary registers' issue.

What issue?  The prefetch instructions "load" to the zero register,
which is never written back to the register file.


r~