From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56052)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Zl2d2-0008Nk-P1
	for qemu-devel@nongnu.org; Sat, 10 Oct 2015 18:28:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Zl2cz-0007Qf-EF
	for qemu-devel@nongnu.org; Sat, 10 Oct 2015 18:28:36 -0400
Received: from mx2.suse.de ([195.135.220.15]:43214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Zl2cz-0007Qb-7x
	for qemu-devel@nongnu.org; Sat, 10 Oct 2015 18:28:33 -0400
References: <1146125127.26155100.1444221853707.JavaMail.zimbra@redhat.com>
	<1444515513-3418-1-git-send-email-afaerber@suse.de>
	<1444515513-3418-2-git-send-email-afaerber@suse.de>
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Message-ID: <5619910E.7080305@suse.de>
Date: Sun, 11 Oct 2015 00:28:30 +0200
MIME-Version: 1.0
In-Reply-To: <1444515513-3418-2-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] ivshmem-test: Implement tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>
Cc: Cam Macdonell <cam@cs.ualberta.ca>, Claudio Fontana <claudio.fontana@huawei.com>

Am 11.10.2015 um 00:18 schrieb Andreas F=C3=A4rber:
> diff --git a/tests/Makefile b/tests/Makefile
> index 3b7e6ac..324829b 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -146,6 +146,8 @@ gcov-files-pci-y +=3D hw/display/virtio-gpu-pci.c
>  gcov-files-pci-$(CONFIG_VIRTIO_VGA) +=3D hw/display/virtio-vga.c
>  check-qtest-pci-y +=3D tests/intel-hda-test$(EXESUF)
>  gcov-files-pci-y +=3D hw/audio/intel-hda.c hw/audio/hda-codec.c
> +check-qtest-pci-$(CONFIG_LINUX) +=3D tests/ivshmem-test$(EXESUF)
> +gcov-files-pci-y +=3D hw/misc/ivshmem.c
> =20
>  check-qtest-i386-y =3D tests/endianness-test$(EXESUF)
>  check-qtest-i386-y +=3D tests/fdc-test$(EXESUF)
> @@ -191,8 +193,6 @@ gcov-files-i386-y +=3D hw/pci-host/q35.c
>  ifeq ($(CONFIG_VHOST_NET),y)
>  check-qtest-i386-$(CONFIG_LINUX) +=3D tests/vhost-user-test$(EXESUF)
>  endif
> -check-qtest-i386-y +=3D tests/ivshmem-test$(EXESUF)
> -gcov-files-i386-y +=3D i386-softmmu/hw/misc/ivshmem.c
>  check-qtest-x86_64-y =3D $(check-qtest-i386-y)
>  gcov-files-i386-y +=3D i386-softmmu/hw/timer/mc146818rtc.c
>  gcov-files-x86_64-y =3D $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-f=
iles-i386-y))
[snip]

This is a quick rebase onto the last version of my older patch. I notice
that the gcov path is different: hw/misc/Makefile.objs has it in obj-y,
not common-obj-y; the .c path counter-intuitively needs to match the .o
file, not the .c file.

Untested whether adding i386-softmmu/ prefix would work for
check-qtest-pci-y, too.

Regards,
Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=
=C3=BCrnberg)