From: Jonathan Cameron <jic23@kernel.org>
To: Shraddha Barke <shraddha.6596@gmail.com>,
outreachy-kernel@googlegroups.com,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] Staging: iio: cdc: Remove unused macros
Date: Sun, 11 Oct 2015 15:10:56 +0100 [thread overview]
Message-ID: <561A6DF0.4050502@kernel.org> (raw)
In-Reply-To: <561A6DCD.8000505@kernel.org>
On 11/10/15 15:10, Jonathan Cameron wrote:
> On 07/10/15 21:38, Shraddha Barke wrote:
>> Remove the macros since they are not used anywhere throughout the
>> kernel.
>>
>> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> Hi Shraddha,
>
> This should have been cc'd to linux-iio and Lars-Peter Clausen
> (who maintains all the Analog devices drivers).
>
> It's straightforward, but worth checking that they are fine with this.
That would have worked better if I'd then remembered to CC them myself.
Sorry!
>
> Jonathan
>> ---
>> drivers/staging/iio/cdc/ad7746.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
>> index 028b4e8..a4bb152 100644
>> --- a/drivers/staging/iio/cdc/ad7746.c
>> +++ b/drivers/staging/iio/cdc/ad7746.c
>> @@ -27,11 +27,7 @@
>>
>> #define AD7746_REG_STATUS 0
>> #define AD7746_REG_CAP_DATA_HIGH 1
>> -#define AD7746_REG_CAP_DATA_MID 2
>> -#define AD7746_REG_CAP_DATA_LOW 3
>> #define AD7746_REG_VT_DATA_HIGH 4
>> -#define AD7746_REG_VT_DATA_MID 5
>> -#define AD7746_REG_VT_DATA_LOW 6
>> #define AD7746_REG_CAP_SETUP 7
>> #define AD7746_REG_VT_SETUP 8
>> #define AD7746_REG_EXC_SETUP 9
>> @@ -39,11 +35,8 @@
>> #define AD7746_REG_CAPDACA 11
>> #define AD7746_REG_CAPDACB 12
>> #define AD7746_REG_CAP_OFFH 13
>> -#define AD7746_REG_CAP_OFFL 14
>> #define AD7746_REG_CAP_GAINH 15
>> -#define AD7746_REG_CAP_GAINL 16
>> #define AD7746_REG_VOLT_GAINH 17
>> -#define AD7746_REG_VOLT_GAINL 18
>>
>> /* Status Register Bit Designations (AD7746_REG_STATUS) */
>> #define AD7746_STATUS_EXCERR BIT(3)
>>
>
next prev parent reply other threads:[~2015-10-11 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 20:38 [PATCH] Staging: iio: cdc: Remove unused macros Shraddha Barke
[not found] ` <561A6DCD.8000505@kernel.org>
2015-10-11 14:10 ` Jonathan Cameron [this message]
2015-10-25 13:38 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2015-10-16 5:20 Shraddha Barke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561A6DF0.4050502@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.