From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Date: Mon, 12 Oct 2015 00:51:51 +0000 Subject: Re: [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures Message-Id: <561B0427.5050207@gmail.com> List-Id: References: <1444565889-27074-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1444565889-27074-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall , David Airlie Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/11/2015 10:18 PM, Julia Lawall wrote: > These nvkm_object_func structures are never modified. All other > nvkm_object_func structures are declared as const. > > Done with the help of Coccinelle. I've picked up the patch, thanks! Ben. > > Signed-off-by: Julia Lawall > > --- drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c | 2 +- > drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 2 +- 2 > files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c > b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c index > 62d3fb6..2be8463 100644 --- > a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c +++ > b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c @@ -109,7 > +109,7 @@ nv04_disp_mthd(struct nvkm_object *object, u32 mthd, void > *data, u32 size) return -EINVAL; } > > -static struct nvkm_object_func +static const struct > nvkm_object_func nv04_disp_root = { .mthd = nv04_disp_mthd, .ntfy > nvkm_disp_ntfy, diff --git > a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c > b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c index > 0db9be2..2721592 100644 --- > a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c +++ > b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c @@ -633,7 +633,7 @@ > nvkm_perfmon_dtor(struct nvkm_object *object) return perfmon; } > > -static struct nvkm_object_func +static const struct > nvkm_object_func nvkm_perfmon = { .dtor = nvkm_perfmon_dtor, .mthd > = nvkm_perfmon_mthd, > > _______________________________________________ dri-devel mailing > list dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWGwQdAAoJEHYLnGJQkpH74lsQAMlUrNJ9gRc1d6P6fKcTwVGa YwBG8R2pg+nQ4UY9GoFvTJO1CSanG+4bLM88ccTDeuF7nIhV9g7Z8vPg8Jy1B2ZX V7mVvNdO+sagYT6PcitXzDDirM6yoNZLf+7y0I+8HPNwg9TBCXUFZCF0w3DY0Txu S6HZmCO/rlhQJFGuOsOrfKAtrEwIaw1JiAWMS8VUNbjdzHgozetJQgq7xAoe49A2 GGtQ6b1JtI8bmzYDVhJmhSqzTwBmZO5RLL6Wo3DFta/E6bR6SQgpeU2im9lkwgKH WOBkotpg/EJJ4ltSMpjOkJlTu5xWEUr12RA5SYlcyWEX7XwnLX7S4TXa8Dh6jIFE Jv4tnWsKVFrzLKQ/Q75uaFgbhJiWt8VNpfGaLmnnI3qYjujAoXBgiapp7Xi/fd25 vUx1j/OWmKQy3dDdjAQKXDp2MK+DrJig7lfQahwGQRztLwvMv65hq7fXLlt0LbjH DzU9Q2VzSbEfW02zDcgCem7gIUf+X3cKkMx2c9Bok56cGOybUPm33OFFZ5IE0KJ4 3yRHE5aq2kzeWsN99N/IvyE6WhtK+kCNmEfkddYOvPQ3XioAk1zjNAdkQudM0Ii0 JWjFFVt0fixVOl8zmGIDNFNBnzYKu5SwvA31Usr1Vsltx+c4LXAmIGG6/vey5Uiv WmpIfcA3EmL2jRoaS/DG y+ -----END PGP SIGNATURE----- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Subject: Re: [PATCH] drm/nouveau/disp, pm: constify nvkm_object_func structures Date: Mon, 12 Oct 2015 10:51:51 +1000 Message-ID: <561B0427.5050207@gmail.com> References: <1444565889-27074-1-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2306C6E1E0 for ; Sun, 11 Oct 2015 17:51:40 -0700 (PDT) Received: by pablk4 with SMTP id lk4so138607199pab.3 for ; Sun, 11 Oct 2015 17:51:39 -0700 (PDT) In-Reply-To: <1444565889-27074-1-git-send-email-Julia.Lawall@lip6.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall , David Airlie Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQpIYXNoOiBTSEEyNTYKCk9uIDEwLzEx LzIwMTUgMTA6MTggUE0sIEp1bGlhIExhd2FsbCB3cm90ZToKPiBUaGVzZSBudmttX29iamVjdF9m dW5jIHN0cnVjdHVyZXMgYXJlIG5ldmVyIG1vZGlmaWVkLiAgQWxsIG90aGVyIAo+IG52a21fb2Jq ZWN0X2Z1bmMgc3RydWN0dXJlcyBhcmUgZGVjbGFyZWQgYXMgY29uc3QuCj4gCj4gRG9uZSB3aXRo IHRoZSBoZWxwIG9mIENvY2NpbmVsbGUuCkkndmUgcGlja2VkIHVwIHRoZSBwYXRjaCwgdGhhbmtz IQoKQmVuLgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBKdWxpYSBMYXdhbGwgPEp1bGlhLkxhd2FsbEBs aXA2LmZyPgo+IAo+IC0tLSBkcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmttL2VuZ2luZS9kaXNw L3Jvb3RudjA0LmMgfCAgICAyICstIAo+IGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vZW5n aW5lL3BtL2Jhc2UuYyAgICAgICB8ICAgIDIgKy0gMgo+IGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L25vdXZlYXUvbnZrbS9lbmdpbmUvZGlzcC9yb290bnYwNC5jCj4gYi9kcml2ZXJzL2dwdS9kcm0v bm91dmVhdS9udmttL2VuZ2luZS9kaXNwL3Jvb3RudjA0LmMgaW5kZXgKPiA2MmQzZmI2Li4yYmU4 NDYzIDEwMDY0NCAtLS0KPiBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vZW5naW5lL2Rp c3Avcm9vdG52MDQuYyArKysKPiBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vZW5naW5l L2Rpc3Avcm9vdG52MDQuYyBAQCAtMTA5LDcKPiArMTA5LDcgQEAgbnYwNF9kaXNwX210aGQoc3Ry dWN0IG52a21fb2JqZWN0ICpvYmplY3QsIHUzMiBtdGhkLCB2b2lkCj4gKmRhdGEsIHUzMiBzaXpl KSByZXR1cm4gLUVJTlZBTDsgfQo+IAo+IC1zdGF0aWMgc3RydWN0IG52a21fb2JqZWN0X2Z1bmMg K3N0YXRpYyBjb25zdCBzdHJ1Y3QKPiBudmttX29iamVjdF9mdW5jIG52MDRfZGlzcF9yb290ID0g eyAubXRoZCA9IG52MDRfZGlzcF9tdGhkLCAubnRmeSA9Cj4gbnZrbV9kaXNwX250ZnksIGRpZmYg LS1naXQKPiBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vZW5naW5lL3BtL2Jhc2UuYwo+ IGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9lbmdpbmUvcG0vYmFzZS5jIGluZGV4Cj4g MGRiOWJlMi4uMjcyMTU5MiAxMDA2NDQgLS0tCj4gYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9u dmttL2VuZ2luZS9wbS9iYXNlLmMgKysrCj4gYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmtt L2VuZ2luZS9wbS9iYXNlLmMgQEAgLTYzMyw3ICs2MzMsNyBAQAo+IG52a21fcGVyZm1vbl9kdG9y KHN0cnVjdCBudmttX29iamVjdCAqb2JqZWN0KSByZXR1cm4gcGVyZm1vbjsgfQo+IAo+IC1zdGF0 aWMgc3RydWN0IG52a21fb2JqZWN0X2Z1bmMgK3N0YXRpYyBjb25zdCBzdHJ1Y3QKPiBudmttX29i amVjdF9mdW5jIG52a21fcGVyZm1vbiA9IHsgLmR0b3IgPSBudmttX3BlcmZtb25fZHRvciwgLm10 aGQKPiA9IG52a21fcGVyZm1vbl9tdGhkLAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fIGRyaS1kZXZlbCBtYWlsaW5nCj4gbGlzdCBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnIAo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiAKLS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0K VmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUVCQ0FBR0JRSldHd1FkQUFvSkVIWUxuR0pRa3BINzRs c1FBTWxVck5KOWdSYzFkNlA2ZktjVHdWR2EKWXdCRzhSMnBnK25RNFVZOUdvRnZUSk8xQ1Nhbkcr NGJMTTg4Y2NURGV1RjduSWhWOWc3Wjh2UGc4SnkxQjJaWApWN21Wdk5kTytzYWdZVDZQY2l0WHpE RGlyTTZ5b05aTGYrN3kwSSs4SFBOd2c5VEJDWFVGWkNGMHczRFkwVHh1ClM2SFptQ08vcmxoUUpG R3VPc09yZktBdHJFd0lhdzFKaUFXTVM4VlVOYmpkekhnb3pldEpRZ3E3eEFvZTQ5QTIKR0d0UTZi MUp0SThibXpZRFZoSm1oU3F6VHdCbVpPNVJMTDZXbzNERnRhL0U2YlI2U1FncGVVMmltOWxrd2dL SApXT0Jrb3RwZy9FSko0bHRTTXBqT2tKbFR1NXhXRVVyMTJSQTVTWWxjeVdFWDdYd25MWDdTNFRY YThEaDZqSUZFCkp2NHRuV3NLVkZyekxLUS9RNzV1YUZnYmhKaVd0OFZOcGZHYUxtbm5JM3FZanVq QW9YQmdpYXBwN1hpL2ZkMjUKdlV4MWovT1dtS1F5M2REZGpBUUtYRHAyTUsrRHJKaWc3bGZRYWh3 R1FSenRMd3ZNdjY1aHE3ZlhMbHQwTGJqSApEelU5UTJWelNiRWZXMDJ6RGNnQ2VtN2dJVWYrWDNj S2tNeDJjOUJvazU2Y0dPeWJVUG0zM09GRlo1SUUwS0o0CjN5UkhFNWFxMmt6ZVdzTjk5Ti9JdnlF NldodEsra0NObUVma2RkWU92UFEzWGlvQWsxempOQWRrUXVkTTBJaTAKSldqRkZWdDBmaXhWT2w4 em1HSURORk5CbnpZS3U1U3d2QTMxVXNyMVZzbHR4K2M0TFhBbUlHRzYvdmV5NVVpdgpXbXBJZmNB M0VtTDJqUm9hUy9ERwo9MDB5KwotLS0tLUVORCBQR1AgU0lHTkFUVVJFLS0tLS0KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbbJLAvl (ORCPT ); Sun, 11 Oct 2015 20:51:41 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35507 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbbJLAvk (ORCPT ); Sun, 11 Oct 2015 20:51:40 -0400 Subject: Re: [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures To: Julia Lawall , David Airlie References: <1444565889-27074-1-git-send-email-Julia.Lawall@lip6.fr> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Ben Skeggs Message-ID: <561B0427.5050207@gmail.com> Date: Mon, 12 Oct 2015 10:51:51 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444565889-27074-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/11/2015 10:18 PM, Julia Lawall wrote: > These nvkm_object_func structures are never modified. All other > nvkm_object_func structures are declared as const. > > Done with the help of Coccinelle. I've picked up the patch, thanks! Ben. > > Signed-off-by: Julia Lawall > > --- drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c | 2 +- > drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 2 +- 2 > files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c > b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c index > 62d3fb6..2be8463 100644 --- > a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c +++ > b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c @@ -109,7 > +109,7 @@ nv04_disp_mthd(struct nvkm_object *object, u32 mthd, void > *data, u32 size) return -EINVAL; } > > -static struct nvkm_object_func +static const struct > nvkm_object_func nv04_disp_root = { .mthd = nv04_disp_mthd, .ntfy = > nvkm_disp_ntfy, diff --git > a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c > b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c index > 0db9be2..2721592 100644 --- > a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c +++ > b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c @@ -633,7 +633,7 @@ > nvkm_perfmon_dtor(struct nvkm_object *object) return perfmon; } > > -static struct nvkm_object_func +static const struct > nvkm_object_func nvkm_perfmon = { .dtor = nvkm_perfmon_dtor, .mthd > = nvkm_perfmon_mthd, > > _______________________________________________ dri-devel mailing > list dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWGwQdAAoJEHYLnGJQkpH74lsQAMlUrNJ9gRc1d6P6fKcTwVGa YwBG8R2pg+nQ4UY9GoFvTJO1CSanG+4bLM88ccTDeuF7nIhV9g7Z8vPg8Jy1B2ZX V7mVvNdO+sagYT6PcitXzDDirM6yoNZLf+7y0I+8HPNwg9TBCXUFZCF0w3DY0Txu S6HZmCO/rlhQJFGuOsOrfKAtrEwIaw1JiAWMS8VUNbjdzHgozetJQgq7xAoe49A2 GGtQ6b1JtI8bmzYDVhJmhSqzTwBmZO5RLL6Wo3DFta/E6bR6SQgpeU2im9lkwgKH WOBkotpg/EJJ4ltSMpjOkJlTu5xWEUr12RA5SYlcyWEX7XwnLX7S4TXa8Dh6jIFE Jv4tnWsKVFrzLKQ/Q75uaFgbhJiWt8VNpfGaLmnnI3qYjujAoXBgiapp7Xi/fd25 vUx1j/OWmKQy3dDdjAQKXDp2MK+DrJig7lfQahwGQRztLwvMv65hq7fXLlt0LbjH DzU9Q2VzSbEfW02zDcgCem7gIUf+X3cKkMx2c9Bok56cGOybUPm33OFFZ5IE0KJ4 3yRHE5aq2kzeWsN99N/IvyE6WhtK+kCNmEfkddYOvPQ3XioAk1zjNAdkQudM0Ii0 JWjFFVt0fixVOl8zmGIDNFNBnzYKu5SwvA31Usr1Vsltx+c4LXAmIGG6/vey5Uiv WmpIfcA3EmL2jRoaS/DG =00y+ -----END PGP SIGNATURE-----