From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Guillaume Picquet <guillaume@picquet.fr>, linux-can@vger.kernel.org
Subject: Re: SocketCAN stops read after RX overflow, is it normal?
Date: Mon, 12 Oct 2015 11:15:40 +0200 [thread overview]
Message-ID: <561B7A3C.20500@pengutronix.de> (raw)
In-Reply-To: <561B7781.4040906@picquet.fr>
[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]
On 10/12/2015 11:04 AM, Guillaume Picquet wrote:
> Le 12/10/2015 10:54, Marc Kleine-Budde a écrit :
>> On 10/12/2015 10:05 AM, Guillaume Picquet wrote:
>>> I've received a patched firmware from my provider, tested it and so far
>>> so good.
>> Good to hear that. Can you send the patches or at91_can.c to the list?
> It's your patch I gave my provider.
>
> https://git.kernel.org/cgit/linux/kernel/git/mkl/linux-can-next.git/commit/?h=at91-next&id=7234e9dee7d0df75de7ae14443a2306435750594
Ah, good to hear that this works for your usecase aswell. Can I add your
Tested-by Tag to the patch?
>>> I've connected 2 devices (AT91 based) at 1Mb/s.
>>> So far more than 470000000 frames received so far.
>>> From the user-space point of view it's much better.
>>> Now the only way to know if rx overflow occur is to set SO_RXQ_OVFL
>>> flag, use recvmsg and check ancillary data.
>> No, that's not correct. With SO_RXQ_OVFL you'll detect overflows of the
>> socket. When there are overflows in the hardware the rx overrun in per
>> device statistics will be increased (see ifconfig) output.
> Ok good to know.
> So your saying that if I receive nothing on a socket with CAN_ERR_MASK
> set 0x1FFFFFFFU it means that the hardware is handling CAN traffic well !
Yes.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2015-10-12 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 10:17 SocketCAN stops read after RX overflow, is it normal? Guillaume Picquet
2015-09-03 9:01 ` Marc Kleine-Budde
2015-10-12 8:05 ` Guillaume Picquet
2015-10-12 8:54 ` Marc Kleine-Budde
2015-10-12 9:04 ` Guillaume Picquet
2015-10-12 9:15 ` Marc Kleine-Budde [this message]
2015-10-12 9:46 ` Guillaume Picquet
2015-10-12 9:50 ` Marc Kleine-Budde
2015-09-03 9:16 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561B7A3C.20500@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=guillaume@picquet.fr \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.