From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] build: don't shadow debug with "@debug@" in
	tools build
Date: Mon, 12 Oct 2015 10:17:48 +0100
Message-ID: <561B7ABC.9040605@citrix.com>
References: <1444574483-1990-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=720401890=George.Dunlap@citrix.com>)
	id 1ZlZFO-0002aw-FS
	for xen-devel@lists.xenproject.org; Mon, 12 Oct 2015 09:18:22 +0000
In-Reply-To: <1444574483-1990-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Fabio Fantoni <fabio.fantoni@m2r.biz>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 11/10/15 15:41, Wei Liu wrote:
> In 16181cbb (tools: Honor Config.mk debug value, rather than setting our
> own), configure doesn't set debug variable anymore. There is, however,
> one place that was missed. The file config/Tools.mk.in was still
> expecting a @debug@ value from configure. After 16181cbb that value
> remained "debug := @debug@" all the time because configure didn't
> substitute it.
> 
> The consequence was that we couldn't get a debug build even if debug was
> set to "y" in Config.mk.
> 
> Fix this by removing the stray line "debug := @debug@" in Tools.mk.in.
> 
> Reported-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Oops -- tested not turning it on, but didn't test turning it on. :-)

Acked-by: George Dunlap <george.dunlap@citrix.com>

> ---
> Cc: Fabio Fantoni <fabio.fantoni@m2r.biz>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> 
> Backport candidate for 4.6.
> ---
>  config/Tools.mk.in | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 9bd5f6c..ccfe137 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -5,9 +5,6 @@ ifeq ($(CONFIG_RUMP),y)
>  XEN_OS              := NetBSDRump
>  endif
>  
> -# A debug build of tools?
> -debug               := @debug@
> -
>  # Tools path
>  BISON               := @BISON@
>  FLEX                := @FLEX@
>