All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/zic: bump version to 2015g
Date: Mon, 12 Oct 2015 12:12:20 +0100	[thread overview]
Message-ID: <561B9594.3070604@imgtec.com> (raw)
In-Reply-To: <1444647391-22164-1-git-send-email-martin@barkynet.com>

Dear Martin Bark,

thanks for your contributions. Below are some comments, please scroll down:

On 10/12/2015 11:56 AM, Martin Bark wrote:
> Signed-off-by: Martin Bark <martin@barkynet.com>
> ---
>  package/zic/zic.hash | 4 ++--
>  package/zic/zic.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/zic/zic.hash b/package/zic/zic.hash
> index 67a6c6d..3014d02 100644
> --- a/package/zic/zic.hash
> +++ b/package/zic/zic.hash
> @@ -1,2 +1,2 @@
> -# From 2015f release anouncement.  See http://mm.icann.org/pipermail/tz-announce/2015-August/000033.html
> -sha512  5cfbebde8a0be57e8388a7b6d35aeba99130a72c1a41f9bbd5d5864511a473aa5e9320ab21055b4383e64b3b9d7682c0d30377ce8407619987be672436014710  tzcode2015f.tar.gz
> +# From 2015g release anouncement.  See http://mm.icann.org/pipermail/tz-announce/2015-October/000034.html

Perhaps we could change that comment to follow the Buildroot's way, like
this:

# From: http://mm.icann.org/pipermail/tz-announce/2015-October/000034.html

The same applies to your patch for bumping tzdata version.

> +sha512  44da833da3afdb82636a953785372bb4c765e61e40d700da40b46ab70007ebdbde4d480e10b87cbb36c45eaaffcaa6b9894375e2f553b7d16655dc167cd4a11f  tzcode2015g.tar.gz
> diff --git a/package/zic/zic.mk b/package/zic/zic.mk
> index e4cc1d3..0bcb800 100644
> --- a/package/zic/zic.mk
> +++ b/package/zic/zic.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -ZIC_VERSION = 2015f
> +ZIC_VERSION = 2015g
>  ZIC_SOURCE = tzcode$(ZIC_VERSION).tar.gz
>  ZIC_SITE = ftp://ftp.iana.org/tz/releases

The tarballs are also available from http, so better switching to it in
order to prevent problems for people behind firewalls:

ZIC_SITE = http://www.iana.org/time-zones/repository/releases

The same applies to your patch for bumping tzdata version.

Regards,

Vincent.

  parent reply	other threads:[~2015-10-12 11:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 10:56 [Buildroot] [PATCH 1/2] package/zic: bump version to 2015g Martin Bark
2015-10-12 10:56 ` [Buildroot] [PATCH 2/2] package/tzdata: " Martin Bark
2015-10-12 11:12 ` Vicente Olivert Riera [this message]
2015-10-12 11:32   ` [Buildroot] [PATCH 1/2] package/zic: " Martin Bark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561B9594.3070604@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.