Re: [PATCH] scsi: don't try to load a device handler during async probing

[Hannes Reinecke <hare@suse.de>]

On 10/08/2015 10:25 AM, Christoph Hellwig wrote:
> Request_module gets really unhappy when called from async probing, so
> revert to not auto load device handler modules during the SCSI bus
> scan.  While autoloading would be really useful we never did this
> until 4.3-rc and it turns out that functionality doesn't actually
> work.
> 
> Fixes: 566079 ("dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Paul Mackerras <paulus@ozlabs.org>
> Tested-by: Paul Mackerras <paulus@ozlabs.org>
> ---
>  drivers/scsi/scsi_dh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
> index 0a2168e..d771bec 100644
> --- a/drivers/scsi/scsi_dh.c
> +++ b/drivers/scsi/scsi_dh.c
> @@ -226,7 +226,7 @@ int scsi_dh_add_device(struct scsi_device *sdev)
>  
>  	drv = scsi_dh_find_driver(sdev);
>  	if (drv)
> -		devinfo = scsi_dh_lookup(drv);
> +		devinfo = __scsi_dh_lookup(drv);
>  	if (devinfo)
>  		err = scsi_dh_handler_attach(sdev, devinfo);
>  	return err;
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html