From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: patch "x86/cpufreq: relocate the driver register function" breaks cpu hot(un)plug Date: Mon, 12 Oct 2015 14:25:50 +0100 Message-ID: <561BB4DE.3090604@citrix.com> References: <1444409303.3009.5.camel@citrix.com> <20151009200059.GD23382@l.oracle.com> <561BCF6502000078000AA41A@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zld6w-0006GR-61 for xen-devel@lists.xenproject.org; Mon, 12 Oct 2015 13:25:54 +0000 In-Reply-To: <561BCF6502000078000AA41A@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Konrad Rzeszutek Wilk Cc: "xen-devel@lists.xenproject.org" , Dario Faggioli , Wei Wang List-Id: xen-devel@lists.xenproject.org On 12/10/15 14:19, Jan Beulich wrote: >>>> On 09.10.15 at 22:00, wrote: >> Anyhow it may be due to the fact that cpufreq_register_driver in Xen is now >> '__init' If you remove that little thing would it work? > Before adding this annotation I carefully check all callers, and both > which I could find are themselves __init. Did I overlook any? I agree that the __init status of the function is correct. Other than the register_cpu_notifier() change, there is another change which checks that !driver_data->target == !driver_data->setpolicy which might be having an unintended side effect. ~Andrew