On 10/12/2015 02:03 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 48 +++++++++++++++++++++++++++++------------------- > 1 file changed, 29 insertions(+), 19 deletions(-) > > @@ -4252,11 +4262,9 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend, > case CHARDEV_BACKEND_KIND_FILE: > abort(); > break; > -#ifdef HAVE_CHARDEV_SERIAL > case CHARDEV_BACKEND_KIND_SERIAL: > - chr = qmp_chardev_open_serial(backend->serial, &local_err); > + abort(); > break; > -#endif Another dead break after abort(). Reviewed-by: Eric Blake -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org