From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Mon, 12 Oct 2015 21:52:47 +0300
Subject: [U-Boot] [PATCH 1/2] Kconfig: add CONFIG_BOOTDELAY
In-Reply-To: <CAPnjgZ2mvKMFafWuJJSL=pExCb3Q_4X6YUh4QaeMiJqG6_VgnQ@mail.gmail.com>
References: <1444331432-17763-1-git-send-email-grinberg@compulab.co.il>
 <1444331432-17763-2-git-send-email-grinberg@compulab.co.il>
 <CAPnjgZ2mvKMFafWuJJSL=pExCb3Q_4X6YUh4QaeMiJqG6_VgnQ@mail.gmail.com>
Message-ID: <561C017F.20306@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On 10/09/15 12:36, Simon Glass wrote:
> Hi Igor,
> 
> On 8 October 2015 at 20:10, Igor Grinberg <grinberg@compulab.co.il> wrote:
>> Add CONFIG_BOOTDELAY to the Kconfig.
>> Default it to 3 seconds according to the majority of configs.
>>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>  common/Kconfig | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/common/Kconfig b/common/Kconfig
>> index d98eb19..e13d255 100644
>> --- a/common/Kconfig
>> +++ b/common/Kconfig
>> @@ -100,6 +100,16 @@ config AUTOBOOT_STOP_STR_SHA256
>>           string / password matches a values that is encypted via
>>           a SHA256 hash and saved in the environment.
>>
>> +config BOOTDELAY
>> +       int "Seconds to delay before autobooting"
>> +       default 3
>> +       help
>> +         Delay before automatically booting the default image;
>> +         set to -1 to disable autoboot.
>> +         set to -2 to autoboot with no delay and not check for abort
>> +         (even when CONFIG_ZERO_BOOTDELAY_CHECK is defined).
>> +         See doc/README.autoboot for additional information.
>> +
>>  endmenu
>>
>>  comment "Commands"
>> --
>> 2.4.9
>>
> 
> It's great that you are taking on these difficult ones.

Thanks...

> 
> IMO we should split this config into a few parts:
> 
> - enabling the boot-delay feature
> - setting the boot-delay time
> - whether to allow abort
> - whether to allow abort even when boot delay is 0
> 
> The way it is written -2 sounds like a weird case that would be better
> merged with the last one above.

I completely agree with you. This is indeed the better way, AFAICS.
Although, I'm not sure I can work on this right now.
How about having it currently the way above and adjusting it later
(when one/me has the time to do it)?


-- 
Regards,
Igor.