From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] drm/exynos: fix to detach device of iommu Date: Tue, 13 Oct 2015 14:10:24 +0900 Message-ID: <561C9240.1030903@samsung.com> References: <1443745838-774-1-git-send-email-jy0922.shim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <1443745838-774-1-git-send-email-jy0922.shim@samsung.com> Sender: stable-owner@vger.kernel.org To: Joonyoung Shim , dri-devel@lists.freedesktop.org Cc: stable@vger.kernel.org, sw0312.kim@samsung.com, m.szyprowski@samsung.com List-Id: dri-devel@lists.freedesktop.org Merged. Thanks, Inki Dae 2015=EB=85=84 10=EC=9B=94 02=EC=9D=BC 09:30=EC=97=90 Joonyoung Shim =EC= =9D=B4(=EA=B0=80) =EC=93=B4 =EA=B8=80: > The arm_iommu_detach_device() is a function to detach device of iommu > attached by arm_iommu_attach_device(). The exynos-drm uses > arm_iommu_attach_device() so it should use arm_iommu_detach_device() = to > detach device of iommu, not iommu_detach_device(). > > The drm_release_iommu_mapping() is a function to release mapping of > iommu created by arm_iommu_create_mapping(). It is called by > exynos_drm_unload() so shouldn't be called by drm_iommu_detach_device= (). > > Signed-off-by: Joonyoung Shim > Cc: # v3.8+ > --- > drivers/gpu/drm/exynos/exynos_drm_iommu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c b/drivers/gpu/= drm/exynos/exynos_drm_iommu.c > index 055e8ec..d73b9ad 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c > @@ -139,6 +139,5 @@ void drm_iommu_detach_device(struct drm_device *d= rm_dev, > if (!mapping || !mapping->domain) > return; > > - iommu_detach_device(mapping->domain, subdrv_dev); > - drm_release_iommu_mapping(drm_dev); > + arm_iommu_detach_device(subdrv_dev); > } >