All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: Fix memcpy_sz for remaining count/rwsize
Date: Tue, 13 Oct 2015 10:09:35 +0200	[thread overview]
Message-ID: <561CBC3F.9040707@gmail.com> (raw)
In-Reply-To: <20151013080058.GC7858@pengutronix.de>

On 13.10.2015 10:00, Sascha Hauer wrote:
> On Mon, Oct 12, 2015 at 08:51:54PM +0200, Sebastian Hesselbarth wrote:
>> On 12.10.2015 09:36, Sebastian Hesselbarth wrote:
>> I used
>>
>> memcpy -s /mnt/image.img -d /dev/nand0.u-boot.bb 0 0
>>
>> i.e. I did not specify any rwsize option. Looking at the code,
>> mem_parse_options does initialize mode with 0 and memcpy_sz
>> should use plain memcpy as fallback.
>>
>> However, if I look at include/fcntl.h, I see that O_RWSIZE_8
>> collides with O_CREAT. I think that is the root cause of the
>> 64b memcpy_sz issue I am suffering from?
>
> Oh Damned! /me hiding under a brown paper bag.
>
> I don't know how you are calling memcpy_sz, but that could lead to
> these kind problems.

memcpy_sz is called by fs/fs.c when using memcpy command above.

Sebastian


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-10-13  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08 21:19 [PATCH] fs: Fix memcpy_sz for remaining count/rwsize Sebastian Hesselbarth
2015-10-12  6:11 ` Sascha Hauer
2015-10-12  7:36   ` Sebastian Hesselbarth
2015-10-12 18:51     ` Sebastian Hesselbarth
2015-10-13  8:00       ` Sascha Hauer
2015-10-13  8:09         ` Sebastian Hesselbarth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561CBC3F.9040707@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.