All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tan Xiaojun <tanxiaojun@huawei.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <dougthompson@xmission.com>, <mchehab@osg.samsung.com>,
	<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove
Date: Tue, 13 Oct 2015 16:45:26 +0800	[thread overview]
Message-ID: <561CC4A6.8060401@huawei.com> (raw)
In-Reply-To: <20151013074121.GA17498@pd.tnic>

On 2015/10/13 15:41, Borislav Petkov wrote:
> On Tue, Oct 13, 2015 at 10:22:51AM +0800, Tan Xiaojun wrote:
>> debugfs_remove is used to remove a file or an empty directory from
>> the debugfs filesystem, but mci->debugfs is not empty.
> 
> How exactly do you trigger this? And by "this" I'm not even sure what
> the problem is as your commit message doesn't say. So please explain
> also what the problem is.
> 
> Also, use this branch instead:
> 
> http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
> 
> We did change EDAC debugfs handling recently so your patch doesn't apply
> anymore.
> 
> Thanks.
> 

Sorry, I don't describe it well. I do test like that:
1)open EDAC config and open CONFIG_EDAC_DEBUG
2)insmod a edac_mc module (like i3000_edac or others in drivers/edac/)
3)rmmod this module
4)we can also see files under /sys/kernel/debug/edac/ like "fake_inject"

If you think this patch is OK, I will do patch in your branch and send V2.

Thanks.
Xiaojun



  reply	other threads:[~2015-10-13  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  2:22 [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove Tan Xiaojun
2015-10-13  7:41 ` Borislav Petkov
2015-10-13  8:45   ` Tan Xiaojun [this message]
2015-10-13  9:45     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561CC4A6.8060401@huawei.com \
    --to=tanxiaojun@huawei.com \
    --cc=bp@alien8.de \
    --cc=dougthompson@xmission.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.